Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nicknaming issue with {attack_pct} and {defense_pct} #5506

Closed
Lntnam opened this issue Sep 17, 2016 · 9 comments
Closed

Nicknaming issue with {attack_pct} and {defense_pct} #5506

Lntnam opened this issue Sep 17, 2016 · 9 comments

Comments

@Lntnam
Copy link

Lntnam commented Sep 17, 2016

Expected Behavior

Having set the correct attack and defense perfection on the nick name

Actual Behavior

Many pokemons got 000 for this code.
I have no idea what a 0% attack and defense perfection means...

Your FULL config.json (remove your username, password, gmapkey and any other private info)

http://pastebin.com/wVyyJiP6

Output when issue occurred

[2016-09-17 06:47:42] [NicknamePokemon] 096_31gg38 Renamed to 096_031gg039
[2016-09-17 06:47:47] [NicknamePokemon] 100_99bb40 Renamed to 100_100bb040
[2016-09-17 06:47:52] [NicknamePokemon] 093_43cH12 Renamed to 093_043cH012
[2016-09-17 06:47:58] [NicknamePokemon] 093_99GG99 Renamed to 093_100GG100
[2016-09-17 06:48:03] [NicknamePokemon] 098_00ff00 Renamed to *098_000ff000*
[2016-09-17 06:48:09] [NicknamePokemon] 097_88BA37 Renamed to 097_089BA038
[2016-09-17 06:48:15] [NicknamePokemon] 095_00tg56 Renamed to *095_000tg056*
[2016-09-17 06:48:19] [NicknamePokemon] 094_74Ff78 Renamed to 094_075Ff079
[2016-09-17 06:48:25] [NicknamePokemon] 100_07Tt80 Renamed to 100_008Tt081
[2016-09-17 06:48:30] [NicknamePokemon] 095_39gt00 Renamed to *095_040gt000*
[2016-09-17 06:48:36] [NicknamePokemon] 092_00kK23 Renamed to *092_000kK023*
[2016-09-17 06:48:42] [NicknamePokemon] 096_99NY23 Renamed to 096_100NY023
[2016-09-17 06:48:48] [NicknamePokemon] 14se26/084 Renamed to 084_014se026
[2016-09-17 06:48:54] [NicknamePokemon] 54Sw99/095 Renamed to 095_054Sw100
[2016-09-17 06:48:59] [NicknamePokemon] 61Gg35/093 Renamed to 093_062Gg035
[2016-09-17 06:49:05] [NicknamePokemon] 99WW40/096 Renamed to 096_100WW040
[2016-09-17 06:49:10] [NicknamePokemon] 30Kf99/095 Renamed to 095_030kf100
[2016-09-17 06:49:17] [NicknamePokemon] 09PP67/086 Renamed to 086_009PP068
[2016-09-17 06:49:23] [NicknamePokemon] 00ne65/092 Renamed to *092_000ne066*
[2016-09-17 06:49:29] [NicknamePokemon] 00sD71/094 Renamed to *094_000sD071*
[2016-09-17 06:49:36] [NicknamePokemon] 85tt87/090 Renamed to 090_086tt088
[2016-09-17 06:49:43] [NicknamePokemon] 61Kd99/098 Renamed to 098_061Kd100

Other Information

OS:
Mac
Branch:
dev
Git Commit:
14d1939
Python Version:
2.7.10
Any other relevant files/configs (eg: path files)

@avexus
Copy link

avexus commented Sep 17, 2016

all of a/d/s = 0

@Lntnam
Copy link
Author

Lntnam commented Sep 17, 2016

@avexus so what does that mean?

@rawgni
Copy link
Contributor

rawgni commented Sep 17, 2016

@lntn worst ?

@Lntnam
Copy link
Author

Lntnam commented Sep 17, 2016

@rawgni I just don't know what zero "attack moveset perfection" actually means...

@rawgni
Copy link
Contributor

rawgni commented Sep 17, 2016

@lntn i think it means it's worst.

line 897 inventory.py

                moveset.attack_perfection = \
                    (current_dps - worst_dps) / (best_dps - worst_dps)

ie. your pokemon dps is equal to worst dps. thus moveset.attack_perfection = 0

@Lntnam
Copy link
Author

Lntnam commented Sep 17, 2016

@rawgni I understand now, thank you.
That line of code means I can get the best_dps and worst_dps out of {pokemon.} syntax right?

@rawgni
Copy link
Contributor

rawgni commented Sep 17, 2016

@lntn Not really. Not through {pokemon.} . The stuff available for {pokemon.} are the those in the Pokemon object (line 927 inventory.py)

@Lntnam Lntnam closed this as completed Sep 17, 2016
@avexus
Copy link

avexus commented Sep 17, 2016

@lntn I don't know about the code. But if a = 0 & d = 0 & s = 0, then IV = 0. The worst IV. On the other hand, if a = 15 & d = 15 & s = 15, then IV = 100% = 1. The best IV we can get.
If this is implemented correctly in the code, you could have 0 percent pokemon.

@Lntnam
Copy link
Author

Lntnam commented Sep 17, 2016

@avexus that part about IV I do understand. If you look at my log, the IV is the first 3 digits, which were totally different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants