Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomAlivePause RandomPause runs even disabled #5501

Closed
liejuntao001 opened this issue Sep 17, 2016 · 5 comments
Closed

RandomAlivePause RandomPause runs even disabled #5501

liejuntao001 opened this issue Sep 17, 2016 · 5 comments

Comments

@liejuntao001
Copy link

I notice these run even disabled in config
RandomAlivePause
RandomPause

Your FULL config.json (remove your username, password, gmapkey and any other private info)

 {
    "//NOTE: This task MUST be placed on the top of task list": {},
    "type": "RandomAlivePause",
    "config": {
      "enabled": false,
      "min_duration": "00:00:10",
      "max_duration": "00:10:00",
      "min_interval": "00:05:00",
      "max_interval": "01:30:00"
    }
  },
  {
    "type": "HandleSoftBan"
  },
  {
    "type": "RandomPause",
    "config": {
      "enabled": false,
      "min_duration": "00:00:10",
      "max_duration": "00:10:00",
      "min_interval": "00:10:00",
      "max_interval": "02:00:00"
    }
  },

Output when issue occurred

[2016-09-16 21:09:07] [RandomAlivePause] [INFO] Next random alive pause at 21:24:19, for a duration of 0:06:03
[2016-09-16 21:09:07] [RandomPause] [INFO] Next random pause at 22:01:19, for a duration of 0:08:44

Steps to Reproduce

start bot

Other Information

Branch:
master
Git Commit:
a8ee312

@kureijir
Copy link

Unless I'm mistaken, that's only an output at start of the bot, it won't actually pause at the specified time.

@cmezh
Copy link
Contributor

cmezh commented Sep 21, 2016

@kureijir You're right, but it should be fixed anyway.

@Gobberwart
Copy link
Contributor

Gobberwart commented Sep 22, 2016

#5591 is a blanket approach which will just mask the issue, and potentially break something (although I can't think what to be honest). Suggest fixing the individual randompause and randomalivepause tasks instead/as well.

@cmezh
Copy link
Contributor

cmezh commented Sep 22, 2016

@Gobberwart It is not a issue, just a messages of scheduling functions called from init.

@cmezh
Copy link
Contributor

cmezh commented Sep 26, 2016

#5591 merged.

@cmezh cmezh closed this as completed Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants