Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignored pokemon list not applied in move_to_map_pokemon or catch_pokemon #4887

Closed
iruy opened this issue Aug 29, 2016 · 4 comments
Closed

Ignored pokemon list not applied in move_to_map_pokemon or catch_pokemon #4887

iruy opened this issue Aug 29, 2016 · 4 comments

Comments

@iruy
Copy link

iruy commented Aug 29, 2016

Expected Behavior

Just skip them, and track skipped pokemon number in stats, without showing log. Is this possible?

[FEATURE] Would it be possible to limit Moving towards pokestop XXX log to a distance multiple of 10? If I'm walking slow (eg. min:2, max: 4), I get 2-3 logs every 10 meters

Actual Behavior

[2016-08-29 12:47:00] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:02] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:03] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:04] [moving_to_fort] Moving towards pokestop Free Clouds - 0.07km
[2016-08-29 12:47:07] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:08] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:11] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:13] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:13] [moving_to_fort] Moving towards pokestop Free Clouds - 0.07km
[2016-08-29 12:47:14] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:16] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:18] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:20] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:20] [moving_to_fort] Moving towards pokestop Free Clouds - 0.07km
[2016-08-29 12:47:23] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:25] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:27] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:29] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:29] [moving_to_fort] Moving towards pokestop Free Clouds - 0.06km
[2016-08-29 12:47:31] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:32] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:34] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:36] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:36] [moving_to_fort] Moving towards pokestop Free Clouds - 0.06km
[2016-08-29 12:47:40] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:42] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:44] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:45] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:45] [moving_to_fort] Moving towards pokestop Free Clouds - 0.05km
[2016-08-29 12:47:48] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:49] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:47:51] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:53] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:53] [moving_to_fort] Moving towards pokestop Free Clouds - 0.05km
[2016-08-29 12:47:56] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:47:57] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:00] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:02] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:02] [moving_to_fort] Moving towards pokestop Free Clouds - 0.05km
[2016-08-29 12:48:03] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:05] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:08] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:09] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:09] [moving_to_fort] Moving towards pokestop Free Clouds - 0.05km
[2016-08-29 12:48:12] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:15] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:16] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:18] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:18] [moving_to_fort] Moving towards pokestop Free Clouds - 0.05km
[2016-08-29 12:48:20] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:22] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:24] [pokemon_appeared] Skip ignored Pidgey! [CP 139] [Potential 0.36] [A/D/S 1/14/1]
[2016-08-29 12:48:26] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:26] [moving_to_fort] Moving towards pokestop Free Clouds - 0.04km
[2016-08-29 12:48:29] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:30] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:30] [moving_to_fort] Moving towards pokestop Free Clouds - 0.04km
[2016-08-29 12:48:32] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:33] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:33] [moving_to_fort] Moving towards pokestop Free Clouds - 0.04km
[2016-08-29 12:48:36] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:38] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:40] [pokemon_appeared] Skip ignored Rattata! [CP 149] [Potential 0.69] [A/D/S 11/13/7]
[2016-08-29 12:48:41] [pokemon_appeared] Skip ignored Rattata! [CP 149] [Potential 0.69] [A/D/S 11/13/7]
[2016-08-29 12:48:41] [moving_to_fort] Moving towards pokestop Free Clouds - 0.04km
[2016-08-29 12:48:45] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:47] [pokemon_appeared] Skip ignored Rattata! [CP 149] [Potential 0.69] [A/D/S 11/13/7]
[2016-08-29 12:48:49] [pokemon_appeared] Skip ignored Pidgey! [CP 92] [Potential 0.4] [A/D/S 3/5/10]
[2016-08-29 12:48:51] [pokemon_appeared] Skip ignored Rattata! [CP 149] [Potential 0.69] [A/D/S 11/13/7]

Other Information

OS:

Branch:

Git Commit:

Python Version:

Any other relevant files/configs (eg: path files)

Short Description

Possible solution

How it would help others

@Krago27
Copy link

Krago27 commented Aug 29, 2016

same here. Ignored, moving to it, and capture... wtf man

[2016-08-29 21:14:56] [PokemonCatchWorker] [INFO] [pokemon_appeared] Skip ignored Magikarp! [CP 85] [Potential 0.49] [A/D/S 5/5/12]
[2016-08-29 21:14:59] [PokemonCatchWorker] [INFO] [pokemon_appeared] Skip ignored Magikarp! [CP 85] [Potential 0.49] [A/D/S 5/5/12]
[2016-08-29 21:14:59] [MoveToMapPokemon] [INFO] [move_to_map_pokemon_move_towards] Moving towards Magikarp, 0.07km, left (5 minutes, 55 seconds)
[2016-08-29 21:15:03] [PokemonCatchWorker] [INFO] [pokemon_appeared] A wild Magikarp appeared! [CP 85] [NCP 0.33] [Potential 0.49] [A/D/S 5/5/12]
[2016-08-29 21:15:14] [PokemonCatchWorker] [INFO] [threw_pokeball] Nice Curveball throw! Used Pokeball, with chance 54.12 (62 left)

@mjmadsen mjmadsen added the Bug label Aug 29, 2016
@mjmadsen
Copy link
Contributor

mjmadsen commented Aug 29, 2016

For the devs:
We have our ignore checking inside of pokemon_catch_worker. Need to move it to catch_pokemon.

MoveToMapPokemon doesn't account for the ignore list at all either (I realize it passes the work on). Do we know the pokemon stats when we see one in this file or do we need to go closer? I'd love if this task and move to fort set our closest target, then we move to next target in our stepper. Would solve the issue folks have when very near a pokemon and very near a fort - getting stuck in an endless loop moving back and forth. This is also part of what I'm talking about in #4754

@mjmadsen mjmadsen changed the title Loggin spam 'Skip ignored pokemon...' Ignored pokemon list not applied in move_to_map_pokemon or catch_pokemon Aug 29, 2016
@dummyaja
Copy link

dummyaja commented Aug 29, 2016

Update :
I got capture action again after i update the Map.
thx for replying @mjmadsen

in my case, i got only logs for teleporting action, no capture action
[2016-08-29 22:37:19] [MoveToMapPokemon] [INFO] [move_to_map_pokemon_teleport_to] Teleporting to Magikarp. (0.07km)
[2016-08-29 22:37:19] [MoveToMapPokemon] [INFO] [move_to_map_pokemon_encounter] Encountered Pokemon: Magikarp
[2016-08-29 22:37:21] [MoveToMapPokemon] [INFO] [move_to_map_pokemon_teleport_back] Teleporting back to previous location (-6.10530529848, 106.773468548)

@mjmadsen
Copy link
Contributor

@dummyaja I think that is a separate issue. What is your config (please use 3rd party posting site and give link).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants