Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query/Feature Request] Reload config from time to time #4773

Closed
pranavperfect opened this issue Aug 26, 2016 · 6 comments
Closed

[Query/Feature Request] Reload config from time to time #4773

pranavperfect opened this issue Aug 26, 2016 · 6 comments

Comments

@pranavperfect
Copy link

Short Description

If i make changes to config.json, i shouldn't have to restart the bot to reload the config file

Possible solution

Reload config file at fixed time intervals (possibly Hourly)

How it would help others

If i come across an area with excess of one pokemon that is not in my evolution list, i can add it to evolution list and it will get reloaded and then i can have its evolutions soon.

@maxprzemo
Copy link

maxprzemo commented Aug 26, 2016

It is already added
"live_config_update": {
"enabled": false,
"tasks_only": false
},

Just turn on

"live_config_update": {
  "enabled": true,
  "tasks_only": false
},

You must switch to DEV branch.

git checkout dev

@Gzerox
Copy link
Contributor

Gzerox commented Aug 26, 2016

mh, i was starting to write down some code about this.
@maxprzemo on dev i can't find anything about "live_config_update" neither on pull request.
Am i missing something ?

@maxprzemo
Copy link

Compare your file config.json with config.json.example
https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/configs/config.json.example#L14

@Gzerox
Copy link
Contributor

Gzerox commented Aug 26, 2016

You're right.
But, Why if i use "search on repository" the string "live_config_update", does not show anything about it? :\

@pranavperfect
Copy link
Author

In that case, i will just close the issue and wait for the dev to be merged with master as i'm relying on using the master branch.

Many thanks @maxprzemo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants