Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

META - Unexpected movesets [Complete List] #4323

Closed
k4n30 opened this issue Aug 20, 2016 · 20 comments
Closed

META - Unexpected movesets [Complete List] #4323

k4n30 opened this issue Aug 20, 2016 · 20 comments

Comments

@k4n30
Copy link
Contributor

k4n30 commented Aug 20, 2016

Seems to be quite a few missing, we'll keep this issue open and update regularly. Please only paste relevant information & the mods will update the OP when new ones come up, or old ones are fixed.

  • If it is listed it means it has been identified as a problem
    • If it is struck out it means it has been fixed in dev (but not master)
    • If it is NOT struck out it means it hasn't been fixed in either branch
  • If it's not listed and you know it's a problem, let us know in a comment below
Pri attack/s Spec attack/s Pokemon no. Pokemon name
Pound, Feint Attack Dazzling Gleam 039 Jigglypuff
Mud Slap Mud Bomb, Rock Tomb, Dig 050 Diglett
Mud Slap 051 DugTrio
Mud Slap Dig, Rock Slide, Stone Edge 075 Graveler
Mud Slap Stone Edge 076 Golem
Lick Aqua Jet, Aqua Tail, Icy Wind 086 Seel
Poison Jab Mud Bomb, Sludge 088 Grimer
Lick 089 Muk
Sludge Bomb 094 Gengar
Brick Break 106 Hitmonlee
Hyper Beam 113 Chansey
Tackle Bubble Beam, Power Gem, Swift 120 Staryu
Tackle, Water Gun Hydro Pump, Power Gem, Psychic 121 Starmie
Zen Headbutt Discharge 137 Porygon
Mud Shot 139 Omastar
Blizzard 151 Mew
@mjmadsen mjmadsen changed the title META - Unexpected movesets META - Unexpected movesets [master] Aug 20, 2016
@k4n30 k4n30 changed the title META - Unexpected movesets [master] META - Unexpected movesets [Complete List] Aug 20, 2016
This was referenced Aug 20, 2016
@k4n30
Copy link
Contributor Author

k4n30 commented Aug 21, 2016

ALL ISSUES HAVE NOW BEEN RESOLVED IN DEV AND MASTER - PLEASE UPDATE TO LATEST VERSION

IF YOU ARE STILL HAVING ISSUES PLEASE POST BELOW

@kienthoang
Copy link

Even after updating to the latest version, I'm still getting 2016-08-21 19:28:22,348 [ Pokemon] [ERROR] Unexpected moveset [Lick, Icy Wind] for #86 Seel, please update info in pokemon.json and create issue/PR

@k4n30
Copy link
Contributor Author

k4n30 commented Aug 21, 2016

@kienthoang please indicate the following

Branch:

Git Commit:

@mjmadsen
Copy link
Contributor

Yeah, both Lick and Icy Wind are listed (in both master and dev)

@KingTheRipper
Copy link

A new error apper today with Starmie:
Unexpected moveset [Tackle, Psychic] for #121 Starmie
I try to modify with a complete list, but noting happen

@KingTheRipper
Copy link

KingTheRipper commented Aug 22, 2016

I search a Pokémon Go DB this is the source: GoDB
I change attacks of Starmie with this configuration after check on Source db above and it seems to working:

  {
    "Number": "121",
    "Name": "Starmie",
    "Classification": "Mysterious Pokemon",
    "Type I": [
      "Water"
    ],
    "Type II": [
      "Psychic"
    ],
    "Weaknesses": [
      "Electric",
      "Grass",
      "Bug",
      "Ghost",
      "Dark"
    ],
    "Fast Attack(s)": [
      "Quick Attack",
      "Water Gun",
      "Tackle"
    ],
    "Weight": "80.0 kg",
    "Height": "1.1 m",
    "Previous evolution(s)": [
      {
        "Number": "120",
        "Name": "Staryu"
      }
    ],
    "Special Attack(s)": [
      "Hydro Pump",
      "Power Gem",
      "Psychic"
    ],
    "BaseAttack": 194,
    "BaseDefense": 192,
    "BaseStamina": 120,
    "CaptureRate": 0.16,
    "FleeRate": 0.06
  },

@KingTheRipper
Copy link

KingTheRipper commented Aug 22, 2016

New issue: [Rock Throw, Rock Tomb] for #74 Geodude adding "Rock Tomb"

    "Special Attack(s)": [
      "Dig",
      "Rock Slide",
      "Rock Tomb"
    ],

Now Working

@KingTheRipper
Copy link

KingTheRipper commented Aug 22, 2016

@kienthoang

Seel have change attacks:
Seel Fast Moves: Ice Shard, Lick Seel
Charge Moves: Aqua Jet, Aqua Tail, Icy Wind

Reference here: PokemonGo-db

go to PokemonGo-Bot > data > pokempon.json and change this at line 3541

    "Fast Attack(s)": [
      "Ice Shard",
      "Water Gun",
      "Lick"
    ],

remove "Water Gun"

    "Fast Attack(s)": [
      "Ice Shard",
      "Lick"
    ],

@KingTheRipper
Copy link

@k4n30

If we take a pokemon db from here: pokemongodb

every time when starting bot, maybe we permanently solve this issue

What you think about that?

@mjmadsen
Copy link
Contributor

mjmadsen commented Aug 22, 2016

To some extent, I feel we could avoid this whole problem by not verifying moves. If you want a pokemon that doesn't spawn with that set, we should still keep it. IMO there is no reason to verify the wants against a list. We can expect future changes to movesets. But if a move is removed from a pokemon, those that spawned before the change will still exist as they were.

@julienlavergne
Copy link
Contributor

@mjmadsen
How does the bot would know what move is best if it does not have the full and correct list of all moveset ? This is used to know which Pokemon to keep.

@k4n30
Copy link
Contributor Author

k4n30 commented Aug 23, 2016

Has anyone created a PR for the new moves?

@k4n30
Copy link
Contributor Author

k4n30 commented Aug 26, 2016

Going to close this in 24 hours, if there are no longer any issues

@mjmadsen
Copy link
Contributor

Closing.

@kujourin
Copy link

for #88 Grimer STILL HAVING ISSUES

@pogarek
Copy link
Contributor

pogarek commented Mar 22, 2017

@yuyuks is your caps lock broken ?
If you want to get something fixed, then please be helpfull. Like creating PR yourself or saying what is wrong.

@kujourin
Copy link

@pogarek
"Number": "088",
"Name": "Grimer",
"Classification": "DataNotInGameMaster",
"Type I": [
"Poison"
],
"Weaknesses": [
"DataNotInGameMaster"
],
"Fast Attack(s)": [
"Poison Jab",
"Mud Slap",
"Acid" //Add this
],

@pogarek
Copy link
Contributor

pogarek commented Mar 22, 2017

Thanks. We will try to include it in next PR by from someone from Team.

@pogarek
Copy link
Contributor

pogarek commented Mar 22, 2017

reopening so it would be missed.

@raffo93
Copy link

raffo93 commented Mar 2, 2018

please fix #87 dewgong

[2018-03-02 22:10:00] Unexpected moveset [Ice Shard, Aqua Jet] for #87 Dewgong, please update info in pokemon.json and create issue/PR

"Number": "087",
"Name": "Dewgong",
"Special Attack(s)": [
"Aurora Beam",
"Water Pulse",
"Blizzard",
"Aqua Jet" // Add this
],

@k4n30 k4n30 closed this as completed Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants