Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Order not honored #3589

Closed
Dracon23 opened this issue Aug 11, 2016 · 8 comments
Closed

Task Order not honored #3589

Dracon23 opened this issue Aug 11, 2016 · 8 comments

Comments

@Dracon23
Copy link

Dracon23 commented Aug 11, 2016

Expected Behavior

Bot honors the task order, for example spin pokestops BEFORE catching pokemon

Actual Behavior

Bot catches pokemon first, no matter what I tell it, resulting in it running out of pokeballs and thus stuck in "wild xyz appeared - no usable pokeballs" loop, till I remove catch tasks from config.

Your config.json (remove your credentials and any other private info)

https://gist.github.com/Dracon23/4b296cefd5ed4f09b282fd68d2b2a50e

Steps to Reproduce

  1. Find a spot rich with pokemon and not in spin range of any pokemon.
  2. Let it sit there, catch pokemon, it WILL run out at some point.
  3. Next pokemon appears, loop.

Other Information

OS: Ubuntu Linux 16.04.1 - headless server
Git Commit: a8242f7
Python Version: Python 2.7.12 (default, Jul 1 2016, 15:12:24)

@BriceSD
Copy link
Contributor

BriceSD commented Aug 11, 2016

@Dracon23 Please post your logs

@Dracon23
Copy link
Author

Fresh right now

@Gobberwart
Copy link
Contributor

Interesting. Your log says you have 99 Ultra Balls available. Should the bot not use these if you have no Pokeballs or Great Balls in your inventory? Seems odd to me. The pokemon catch worker should use whatever the lowest available ball is by default:

            current_ball = ITEM_POKEBALL
            while items_stock[current_ball] == 0 and current_ball < maximum_ball:
                current_ball += 1
            if items_stock[current_ball] == 0:
                self.emit_event('no_pokeballs', formatted='No usable pokeballs found!')
                break

I realise this doesn't answer your question, but there appears to be an issue somewhere related to ball selection.

Maybe if no usable balls, then bot should "run away" to avoid getting stuck in a loop?

@BriceSD
Copy link
Contributor

BriceSD commented Aug 11, 2016

@Gobberwart if you’re right and he doesn’t use his ultraball, it’s a known issue and a fix is coming for this. #3421

@smfbrooks
Copy link

Potentially related #3563

@Dracon23
Copy link
Author

Yes, I have ultras.... And i,'ve seen the other issue and was pointed to a fix on slack.

@Dracon23 Dracon23 reopened this Aug 12, 2016
@Dracon23
Copy link
Author

What's bugging me (heh)... Is that he won't continue to a poke stop... He just keeps looping the encounter, and doesn.'t do jack till the mon disappears...

@k4n30
Copy link
Contributor

k4n30 commented Aug 16, 2016

OP Issue resolved

@k4n30 k4n30 closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants