Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] RecycleItems overflows the given limit #3392

Closed
rendyep opened this issue Aug 10, 2016 · 5 comments
Closed

[BUG] RecycleItems overflows the given limit #3392

rendyep opened this issue Aug 10, 2016 · 5 comments

Comments

@rendyep
Copy link

rendyep commented Aug 10, 2016

Hi, I have updated to the latest dev, and seems like now the RecycleItems doesn't function correctly.

Example: I limit the Pokeball to 50, but there are now 81 Pokeballs in my inventory and they keep counting after visiting pokestop.

Here is my json config:

{
    "type": "RecycleItems",
    "config": {
        "min_empty_space": 0,
        "item_filter": {
            "Pokeball":       { "keep" : 50 },
            "Greatball":      { "keep" : 100 },
            "Potion":         { "keep" : 0 },
            "Super Potion":   { "keep" : 20 },
            "Hyper Potion":   { "keep" : 50 },
            "Revive":         { "keep" : 20 },
            "Razz Berry":     { "keep" : 20 }
        }
    }
}
@DK4cm
Copy link

DK4cm commented Aug 10, 2016

"min_empty_space" set to 0, so the recycle will start when the bag is full.
You can remove/comment this line and it will recycle everytime you get a new items.

@TCB13
Copy link

TCB13 commented Aug 13, 2016

@DK4cm I don't have min_empty_space on my config and I'm having the same issue as @rendyep .

@BriceSD
Copy link
Contributor

BriceSD commented Aug 13, 2016

@TCB13 It’s not a bug. The RecycleItems task will run only when your inventory reaches a limit. By default it’s 6. You can change this parameter with min_empty_space. Once you inventory reach 345 items it’ll start discarding items.
Setting min_empty_space to your inventory size should trigger the recycling task every tick

@BriceSD BriceSD closed this as completed Aug 13, 2016
@BriceSD BriceSD reopened this Aug 13, 2016
@TCB13
Copy link

TCB13 commented Aug 13, 2016

@BriceSD great tip! Thanks.

@k4n30
Copy link
Contributor

k4n30 commented Aug 16, 2016

Fixed in latest version

@k4n30 k4n30 closed this as completed Aug 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants