Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

screen spammed when trying to configure 3 rules to release (no action is then taken by bot). #3255

Closed
gilgo opened this issue Aug 9, 2016 · 6 comments

Comments

@gilgo
Copy link

gilgo commented Aug 9, 2016

Expected Behavior

expected to release all pokemon under certain cp but at the same time keep 1 best cp and 1 best iv.

Actual Behavior

when trying to insert 3 rules to the release configuration it fails to take any action and only spams screen:
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Eevee, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Squirtle, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Kabuto, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Pidgeotto, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Dratini, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Ekans, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Clefairy, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Jigglypuff, based on cp and iv
2016-08-09 13:50:05,743 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Golbat, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Oddish, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Paras, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Venonat, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Meowth, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Psyduck, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Poliwag, based on cp and iv
2016-08-09 13:50:05,744 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Bellsprout, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Tentacool, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Tentacruel, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Geodude, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Ponyta, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Slowpoke, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Slowbro, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Magnemite, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Seel, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Shellder, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Cloyster, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Drowzee, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Krabby, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Kingler, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Voltorb, based on cp and iv
2016-08-09 13:50:05,746 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Exeggcute, based on cp and iv
2016-08-09 13:50:05,747 [TransferPokemon] [INFO] [keep_best_release] Keeping best 1 Kangaskhan, based on cp and iv
2016-08-09 13:50:05,747 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Horsea, based on cp and iv
2016-08-09 13:50:05,747 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Goldeen, based on cp and iv
2016-08-09 13:50:05,747 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Seaking, based on cp and iv
2016-08-09 13:50:05,747 [TransferPokemon] [INFO] [keep_best_release] Keeping best 2 Staryu, based on cp and iv

Steps to Reproduce

in config file at tasks section:
"release": {
"any": {"keep_best_cp" : 1, "keep_best_iv": 1, "release_below_cp": 400, "logic": "or"},
},

Other Information

OS: win 7
Git Commit: 6ba5609c6151507b5b832a74e471b6b7b1a182c9
Python Version: 2.7

@umutafacan
Copy link

it do not work like that you should chose keep_best method or release_below, unfortunately.

@paris-ci
Copy link

paris-ci commented Aug 9, 2016

This should be a feature !

CP IV Keep Or Not
10 0.91 Release : CP < 500
900 0.1 Release : IV < 0.7
1400 0.5 Keep : CP > 1300 AND IV > 0.4
1200 0.7 Keep : CP > 500 AND IV > 0.7
10 0.1 Release : CP < 500 AND IV < 0.7
400 0.6 Keep : M. Mime, VIP pokemon override

@umutafacan
Copy link

this is already can be configured but keep_best_cp and release_below should work together

@gilgo
Copy link
Author

gilgo commented Aug 9, 2016

yes that is what im saying, i want to keep the 1 best cp and 1 best iv but at the same time i dont want it to keep anything below 400 cp or to be more exact, the issue is that the best iv pokemon is usually really really weak in cp terms compared to the best cp (i would accept it if its above 400 cp for evolving and power up but below that its not worth the effort*).

*obviously magikarp and some other pokemon are handled as an exception.

@umutafacan
Copy link

yes, i want it too but unfortunately we dont have it.
if i knew python, i might make code for it :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@paris-ci @umutafacan @gilgo @jrjhealey and others