Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not re-raise every exception from main() #3125

Closed
mdeous opened this issue Aug 8, 2016 · 2 comments
Closed

do not re-raise every exception from main() #3125

mdeous opened this issue Aug 8, 2016 · 2 comments

Comments

@mdeous
Copy link

mdeous commented Aug 8, 2016

Expected Behavior

When an error occurs, the stacktrace should show the right code section where it happened.

Actual Behavior

Whatever unexpected error occurs, the stacktrace shows the main() function as the erroneous code location.

Traceback (most recent call last):
  File "pokecli.py", line 502, in <module>
    main()
  File "pokecli.py", line 133, in main
    raise e
WhateverError: any unexpected error occured, I don't know where it happened

Steps to Reproduce

Run the bot until an error occurs.

Other Information

OS: Linux 4.6.4 (ArchLinux)
Git Commit: ae0ae81
Python Version: 2.7.12

@pmquan
Copy link
Contributor

pmquan commented Aug 8, 2016

I believe it's already fixed in PR #2944

@mdeous
Copy link
Author

mdeous commented Aug 8, 2016

you're right, I didn't test the dev branch before posting, my bad.

@mdeous mdeous closed this as completed Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants