Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popping a lucky egg before evolving all #1752

Closed
Donwulff opened this issue Jul 30, 2016 · 1 comment
Closed

Popping a lucky egg before evolving all #1752

Donwulff opened this issue Jul 30, 2016 · 1 comment

Comments

@Donwulff
Copy link

Donwulff commented Jul 30, 2016

Expected Behavior

Bot pops lucky egg before starting to evolve pokemon.

Actual Behavior

Bot doesn't pop lucky egg before starting to evolve pokemon.

Steps to Reproduce

Set...
"evolve_all": "NONE",
"use_lucky_egg": false,
Run bot

Other Information

dev branch

Fix:

evolve_all_worker.py:

# Evolve all is used - Don't run after the first tick or if the config flag is false
        if self.bot.tick_count is not 1 or not self.bot.config.use_lucky_egg:
            return True

tick_count is increased by 1 before running each worker, therefore the first tick is 1, not 0.

@codybaldwin
Copy link
Contributor

codybaldwin commented Jul 30, 2016

Thank you, a recent change to when the tick count is incremented broke this code as you pointed out. I'll submit a PR for the fix.

Update: I have submitted PR #1774 to address this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants