Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep best CP and best IV #1507

Closed
Floriferous opened this issue Jul 28, 2016 · 3 comments
Closed

Keep best CP and best IV #1507

Floriferous opened this issue Jul 28, 2016 · 3 comments

Comments

@Floriferous
Copy link

Expected Behaviour

release: {
"any": {"keep_best_cp": x, "keep_best_iv": y}
}

Lets you keep your x best CP pokemon as well as your y best iv pokemon.

for example:
release: {
"any": {"keep_best_cp": 1, "keep_best_iv": 1}
}

will keep 2 magikarps:

120cp, 0.54iv
10cp, 0.96iv

Actual Behaviour

Currently, setting both appears to only consider the last rule, in this case it will only keep your y best IV pokemon:
release: {
"any": {"keep_best_cp": x, "keep_best_iv": y}
}

Other Information

OS: Mac OS X
Git Commit: 47cf9db

@simonsmh
Copy link
Contributor

It's a good suggestion.

@achretien
Copy link
Contributor

PR #1472

@AdaptCharm
Copy link
Contributor

AdaptCharm commented Jul 28, 2016

PR has already been made, #1472. Closing this for now.

/closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants