[DEV] Not evolving any Pokemon

[lelmac]

Expected Behavior

Bot should evolve Pokémon on startup.

Actual Behavior

He basically skips the evolution(no console log)
[10:04:56] Pokemon Captured: 1309 | Pokestops Visited: 547
[10:04:57] Pokemon Bag: 227/250
[10:04:57] Items: 321/350
[10:04:57] Stardust: 146604 | Pokecoins: 0
[10:04:57] PokeBalls: 48 | GreatBalls: 0 | UltraBalls: 32
[10:04:57] Razz Berries: 74
[10:04:57]
[10:04:57]
[10:04:59] Starting PokemonGo Bot....
[10:04:59] Scanning area for objects....
[10:04:59] Walking from (49.303157, 8.642888) to [49.303157, 8.642888] 0.00km
[========================================] 100%
[10:05:05] Cleaning up Pokemon Bag using the release config
[10:05:05] Pokemon Bag has been cleaned up!
[10:05:05] Using lucky egg ... you have 2
[10:05:06] Found fort 142f22cda073459ab55132cdc45190f0.16 at distance 0.02km
[10:05:06] Need to move closer to Pokestop

Steps to Reproduce

config:
"evolve_all": "all", not working
"evolve_all": "Pidgey,Zubat,Weedle" , does not work either

Other Information

OS: Ubuntu 16.10
Git Commit: 9765828

[Anyrainel]

Same problem here

[StarForser]

The same problem there is a solution?

[sn0opy]

There seems to be a bug in the _should_run() function. You can comment out (put a # in front) the following two lines as a workaround

https://github.com/PokemonGoF/PokemonGo-Bot/blob/dev/pokemongo_bot/cell_workers/evolve_all_worker.py#L16#L17

[codybaldwin]

This issue was caused by PR #1159 by the following addition to evolve_all_worker: 'skip_evolves = False

    if self.config.evolve_all:
        return skip_evolves'

this logic will return false every time the evolve_all config is true. Causing the evolve to be skipped every time.

[ShapeShifter499]

@codybaldwin @sn0opy If I want to have a temporary work around which edit do I use?

[codybaldwin]

as @sn0opy said: in pokemongo_bot\cell_workers\evolve_all_worker.py comment out line 16 and 17 by placing a # in front of them like so
#if not self._should_run():
    #return

I'll be fixing and submitting a PR soon

[ShapeShifter499]

@codybaldwin @sn0opy Workaround is working for me it appears in latest DEV branch. Thank you for the help. Let me know if this ever gets fixed upstream.

[apyapy]

will the workaround work for master?

[ShapeShifter499]

Newest git pull on the DEV branch and still experiencing the above bug. Does the work around still apply?

Other Information

OS: Arch Linux 64bit
Git Commit: 15a0344

[ShapeShifter499]

Workaround mentioned above still works.

Other Information

OS: Arch Linux 64bit
Git Commit: 15a0344

[theadriann]

Submitted a PR here to fix this bug.
#1256

[AdaptCharm]

PR has been opened to fix this issue. When you see this PR has been merged #1256 , update to latest dev branch. Closing this for now.

/closed