Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popover doesn't work in landscape mode #8

Open
BenderNK opened this issue Jan 24, 2019 · 2 comments
Open

Popover doesn't work in landscape mode #8

BenderNK opened this issue Jan 24, 2019 · 2 comments

Comments

@BenderNK
Copy link

BenderNK commented Jan 24, 2019

Thank you for this amazing library. It works really well, and simplifies a developer's life tremendously especially if you are bored with the standard iOS alerts.
However, I noticed that popover orientations are not correct in the landscape mode, including the example project. When you select Bounce from top animation and if you are in landscape orientation, popover slides from left and with the wrong rotation. See screenshot below (I am running the iOS 12.1 version emulator):

simulator screen shot - iphone 8 plus - 2019-01-23 at 20 33 40

When I use the debugger, I can see the code going into the right switch statement in the (void)updateForInterfaceOrientation function but the final frame calculations still happen as though the orientation is portrait. Do you have any plans of adding this as an enhancement?

@Toprakete
Copy link

Is there a solution meanwhile

@rynecheow
Copy link

Hi @Toprakete @BenderNK, I have currently no time to fix the issue... If you could look into why, and send a pull request of the change it would be well appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants