Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ppairDataBuiltin; Make Tracing tests structure consistent with other tests #50

Merged
merged 4 commits into from
Jan 6, 2022
Merged

Add ppairDataBuiltin; Make Tracing tests structure consistent with other tests #50

merged 4 commits into from
Jan 6, 2022

Conversation

TotallyNotChase
Copy link
Collaborator

No description provided.

L-as
L-as requested changes Jan 4, 2022
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment. Thanks for the contribution!

Plutarch/Builtin.hs Show resolved Hide resolved
Plutarch/Builtin.hs Outdated Show resolved Hide resolved
@L-as
Copy link
Member

L-as commented Jan 5, 2022

We have pconstant now.

@TotallyNotChase TotallyNotChase changed the title Finish up with builtin list and builtin pair construction utilities Add ppairDataBuiltin; Make Tracing tests structure consistent with other tests Jan 6, 2022
@TotallyNotChase
Copy link
Collaborator Author

We have pconstant now.

Awesome! Removed the nil stuff. Also removed the pconsBuiltin in favor of having that land in #63

I guess this PR just adds ppairDataBuiltin now lol. Also, I moved out Plutarch.Spec.Tracing and put it inside Examples.Tracing for consistency.

L-as
L-as approved these changes Jan 6, 2022
View reviewed changes
Copy link
Member

@L-as L-as left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@L-as L-as merged commit d0c1baa into master Jan 6, 2022
@TotallyNotChase TotallyNotChase deleted the finish-synonyms branch January 6, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srid srid srid left review comments

@L-as L-as L-as approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TotallyNotChase @L-as @srid