Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behaviour:hat durability - custom durability #4364

Open
4 tasks done
PSYCHEER opened this issue Jan 29, 2025 · 1 comment
Open
4 tasks done

Behaviour:hat durability - custom durability #4364

PSYCHEER opened this issue Jan 29, 2025 · 1 comment
Labels
type: bug Something isn't working
Milestone

Comments

@PSYCHEER
Copy link

Terms

  • I'm using the very latest version of ItemsAdder and its dependencies.
  • I already searched on this Github page to check if the same suggestion was already reported.
  • I already searched on the plugin wiki to know if the feature is already implemented.
  • I already searched on the Discord server to know if anyone already has a solution for this or if the feature was already suggested.

Discord tag (optional)

PSYCHEER

Describe the solution you'd like

Hey there!
You've certainly heard about 3D helmets! These helmets are usually done for cosmetics only.
I want to change this, I want to use them as normal piece of armour.

Durability for these custom helmets can work based on NBT so no need to save them separately!

info:
  namespace: my_items
items:
  my_simple_helmet:
    display_name: my_helmet_simple_helmet
    permission: my_helmet_simple
    behaviour: hat
    resource:
      material: paper
      generate: false
      model_path: helmets/my_threed_helmet
    attribute_modifiers:
      head:
        armor: 9
        armorToughness: 1

This is simple config of it, but for now, 4.0.7, durability doesn't change its behaviour, Minecraft doesn't recognize its durability and I see it as a big disadvantage as it can better this project up!

Is your feature request related to a problem?

A bit, yes, described above.

Describe alternatives you've considered

:| Didn't?

Additional context

No response

@PSYCHEER PSYCHEER added the type: feature request New feature request. label Jan 29, 2025
@LoneDev6
Copy link
Collaborator

LoneDev6 commented Feb 3, 2025

Thank you, this will be fixed.
Durability events are not called for items that don't normally offer durability, in this case PAPER.

@LoneDev6 LoneDev6 moved this from New to Done in ItemsAdder Feb 3, 2025
@LoneDev6 LoneDev6 added type: bug Something isn't working and removed type: feature request New feature request. labels Feb 3, 2025
@LoneDev6 LoneDev6 added this to the 4.0.8 milestone Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants