Stop sounds when emote ends

[mario638]

Terms

• I'm using the very latest version of ItemsAdder and its dependencies.
• I already searched on this Github page to check if the same suggestion was already reported.
• I already searched on the plugin wiki to know if the feature is already implemented.
• I already searched on the Discord server to know if anyone already has a solution for this or if the feature was already suggested.

Discord tag (optional)

No response

Describe the solution you'd like

If emote is stopped, stop the sound too
This could help by doing emote packs because I am doing like dances with music and it repeats if you stop

Is your feature request related to a problem?

No

Describe alternatives you've considered

Using the command /stopsound @e[type=minecraft:player,sort=nearest,distance=10] for example

Additional context

No response

[mario638]

I have seen that distance doesn't work in stopsound so here it would be the command updated stopsound @a[dx=10,dy=10,dz=10,sort=nearest]
Here is a code that I have made in CE (Conditional Events) for making this to work

  event1:
    type: custom
    custom_event_data:
      event: dev.lone.itemsadder.api.Events.PlayerEmoteEndEvent
      player_variable: getPlayer()
    actions:
      default:
      - 'to_range: 10;true: stopsound: all'

[mario638]

@LoneDev6 Bump

[Andre601]

@LoneDev6 Bump

Don't bump issues, or else you will be punished.

[mario638]

@LoneDev6 Bump

Don't bump issues, or else you will be punished.

[mario638]

This could be added using the api or the example I gave

[LoneDev6]

I can add it to the emote yml configuration.
For example something like that:

on_stop:
  stop_sounds: true

[mario638]

Sure and I think is much better

[LoneDev6]

info:
  namespace: iatest
emotes:
  test_emote:
    id: test_emote
    can_player_move: false  # fixed
    hide_equipment:
      helmet: true
      mainhand: true
      offhand: true
    cancel_conditions:
      sneak: true
      deal_damage: true
      in_air: true
      take_damage: true
    on_stop:
      stop_sounds: true  # new option: stops all played sound on emote cancel
      skip_emote_end: true  # new option: interrupts the emote on cancel

[mario638]

What is skip_emote_end for? (any example)

[mario638]

I have found that if you are doing an emote and if you use /emote (otheremote) it doesn't cancel so it doesn't stop sound but at the moment it works really great if you could fix/add that to the code

2025-01-31.17-29-56.mp4

[LoneDev6]

Will be fixed, thanks!

[LoneDev6]

What is skip_emote_end for? (any example)

To avoid the last emote part and directly skip the emote on cancel.
For example if you want to cancel the emote immediately after you press shift instead of showing the last emote part after the loop.