Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

body cosmetic chat bug #235

Open
4 tasks done
dafsdfasde opened this issue Jun 10, 2024 · 11 comments
Open
4 tasks done

body cosmetic chat bug #235

dafsdfasde opened this issue Jun 10, 2024 · 11 comments
Labels
compat: plugin Compatibility with another Spigot plugin type: bug Something isn't working type: other plugin bug This is another plugin bug.

Comments

@dafsdfasde
Copy link

dafsdfasde commented Jun 10, 2024

Terms

  • I'm using the very latest version of CosmeticsCore and its dependencies.
  • I already searched on this Github page to check if the same issue was already reported.
  • I already searched on the plugin wiki to know if a solution is already known.
  • I already searched on the Discord server to know if anyone already provided a solution in the past for the issue.

Discord tag (optional)

No response

What happened?

body cosmetic chat bug

Steps to reproduce the issue

This phenomenon occurs when you chat while wearing body cosmetics.

+) It seems to occur when there are two or more people connected to the server.

Server version

[22:45:52 INFO]: This server is running Paper version git-Paper-196 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 773dd72)
You are running the latest version
Previous version: git-Purpur-2062 (MC: 1.20.1)

CosmeticsCore Version

CosmeticsCore version 1.2.4-release-1

ProtocolLib Version

[22:46:29 INFO]: ProtocolLib version 5.2.1-SNAPSHOT-689
[22:46:29 INFO]: Provides read/write access to the Minecraft protocol.
[22:46:29 INFO]: Authors: dmulloy2 and comphenix

LoneLibs Version

[22:46:34 INFO]: LoneLibs version 1.0.54
[22:46:34 INFO]: Collection of libs used by my plugins
[22:46:34 INFO]: Authors: LoneDev and others

FULL server log

No response

Error (optional)

No response

CosmeticsCore config.yml

No response

Problematic items yml configuration file (optional)

No response

Other files, you can drag and drop them here to upload. (optional)

No response

Screenshots/Videos (you can drag and drop files or paste links)

2024-06-10.22-47-28.mp4
@dafsdfasde dafsdfasde added the type: bug Something isn't working label Jun 10, 2024
@LoneDev6
Copy link
Contributor

Update to 1.20.2, update lonelibs, update protocollib, join with vanilla client without mods.
Let me know

@LoneDev6 LoneDev6 moved this to Need answer in Other plugins Jun 10, 2024
@dafsdfasde
Copy link
Author

If you are unable to implement this phenomenon, please test it after connecting to the server with two or more people.

And since LoneLibs is already the latest version, I will update the ProtocolLib version.

Update to 1.20.2, update lonelibs, update protocollib, join with vanilla client without mods. Let me know

@dafsdfasde
Copy link
Author

@LoneDev6 Update lonelibs, update protocollib, join with vanilla client without mods. I tried all of them, but if more than 2 people are connected to the server, it causes an error in body cosmetic.

@LoneDev6
Copy link
Contributor

Did you update to 1.20.2?

@dafsdfasde
Copy link
Author

1.20.2로 업데이트하셨습니까?

1.20.2 does not allow testing in the same environment.
There are plugins that do not work when updating to version 1.20.2.

Can't the bug be fixed in version 1.20.1?

@dafsdfasde
Copy link
Author

1.20.2로 업데이트하셨습니까?

I have tried using version 1.20.4, but the issue still persists.

@dafsdfasde
Copy link
Author

Did you update to 1.20.2?

I have identified the cause. The issue occurs when there are two or more players connected to the server along with CMI.

@dafsdfasde
Copy link
Author

1.20.2로 업데이트, lonelibs 업데이트, protocollib 업데이트, 모드 없이 바닐라 클라이언트와 결합. 알려주세요

Sorry to keep bringing this up, but I found out the reason why the body cosmetic drops when I type in the chat. It's because of a conflict with the cmi ChatBubble system. Can you help resolve this issue?

@LoneDev6
Copy link
Contributor

LoneDev6 commented Sep 3, 2024

Seems that the chat bubbles plugin is doing something with the passengers packets of the player.
I too do that to render cosmetics, but I make sure to not conflict with other plugins player passengers because I inject mines instead of replacing them.
They might are replacing them instead.

Can you link this issue to its developer so that we can discuss?

@LoneDev6 LoneDev6 added compat: plugin Compatibility with another Spigot plugin type: other plugin bug This is another plugin bug. labels Sep 3, 2024
@Pattanawaris
Copy link

according to this I got 1 dev that provide access to their code on how he dealing with Setpassengers packets from other plugins. And he told me to send this to Cosmetics plugins's dev.
https://github.com/Xiao-MoMi/Custom-Nameplates/blob/main/platforms/bukkit/src/main/java/net/momirealms/customnameplates/bukkit/BukkitPlatform.java#L271

@Pattanawaris
Copy link

Seems that the chat bubbles plugin is doing something with the passengers packets of the player. I too do that to render cosmetics, but I make sure to not conflict with other plugins player passengers because I inject mines instead of replacing them. They might are replacing them instead.

Can you link this issue to its developer so that we can discuss?

I need to quote a reply instead of commenting i guess.
according to this I got 1 dev that provide access to their code on how he dealing with Setpassengers packets from other plugins. And he told me to send this to Cosmetics plugins's dev.
https://github.com/Xiao-MoMi/Custom-Nameplates/blob/main/platforms/bukkit/src/main/java/net/momirealms/customnameplates/bukkit/BukkitPlatform.java#L271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compat: plugin Compatibility with another Spigot plugin type: bug Something isn't working type: other plugin bug This is another plugin bug.
Projects
Status: Stalled: need answer
Development

No branches or pull requests

3 participants