Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change array access code #7

Open
JosephLenton opened this issue Dec 15, 2012 · 1 comment
Open

change array access code #7

JosephLenton opened this issue Dec 15, 2012 · 1 comment

Comments

@JosephLenton
Copy link
Member

Array access code is slow, and needs optimizing, so that it can access the array element directly.

Specifically, remove the QubyArray class, and instead have it extend the standard Array prototype instead. So there is no array wrapper.

@JosephLenton
Copy link
Member Author

Currently it uses a polymorphic 'quby_getCollection' to return values from a collection, and wraps arrays within a QubyArray.

An improved version could try adding the QubyArray functionality to the Array prototype, such as a 'quby_get' instead of 'quby_getCollection'. Generated code could also assert it exists, before access.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant