Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce error reporting in GameServer controller #398

Merged
merged 2 commits into from
Sep 20, 2022
Merged

reduce error reporting in GameServer controller #398

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a7ccf2
reduce errors in GameServer controller
dgkanatsios Sep 19, 2022
921974d
updating comment
dgkanatsios Sep 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pkg/operator/controllers/gameserver_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,11 @@ func (r *GameServerReconciler) Reconcile(ctx context.Context, req ctrl.Request)
}
// updating GameServer with the new state
if err := r.Status().Patch(ctx, &gs, patch); err != nil {
return ctrl.Result{}, err
// there is a chance that we have arrived here while the GameServer has been deleted
// in this case, .Patch will fail with NotFound error and we can safely ignore it
if !apierrors.IsNotFound(err) {
return ctrl.Result{}, err
}
}
return ctrl.Result{}, nil
}
Expand Down