Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

override compute grid to force use of user-supplied grid #688

Closed
ddudt opened this issue Sep 27, 2023 · 0 comments · Fixed by #716
Closed

override compute grid to force use of user-supplied grid #688

ddudt opened this issue Sep 27, 2023 · 0 comments · Fixed by #716
Assignees
@f0uriest
Labels
easy Short and simple to code or review enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc interface New feature or request to make the code more usable or compatibility with another code low priority Nice to have, but not needed right away

Comments

@ddudt
Copy link
Collaborator

ddudt commented Sep 27, 2023

Presently, the compute logic will increase the grid resolution if the user supplies a grid with insufficient resolution. For example, when computing quantities that rely on flux surface averages. We should add an option to override this default and use the user-supplied grid if desired.
@ddudt ddudt added interface New feature or request to make the code more usable or compatibility with another code low priority Nice to have, but not needed right away enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc labels Sep 27, 2023
@dpanici dpanici added the easy Short and simple to code or review label Oct 18, 2023
@f0uriest f0uriest mentioned this issue Oct 19, 2023
Merged
@f0uriest f0uriest mentioned this issue Feb 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@f0uriest f0uriest

Labels
easy Short and simple to code or review enhancement General label for enhancement. Please also tag with "Speed", "Interface", "Functionality", etc interface New feature or request to make the code more usable or compatibility with another code low priority Nice to have, but not needed right away
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Going for the record of most issues fixed in a single PR PlasmaControl/DESC
3 participants
@f0uriest @ddudt @dpanici