Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coils #495

Closed
5 tasks done
f0uriest opened this issue Apr 27, 2023 · 1 comment
Closed
5 tasks done

Coils #495

f0uriest opened this issue Apr 27, 2023 · 1 comment
Assignees

Comments

@f0uriest
Copy link
Member

f0uriest commented Apr 27, 2023

Basics:

  • each coil/curve has its own parameterization, knows how to compute basic stuff (position along coil etc)
  • base class takes care of more general derived quantities
  • make general compute method for coils with default grid/transform or user supplied (so we can use different grids for different objectives
  • Objectives are bound to certain coils/coilsets/equilibria with build method
  • Objective.compute uses bound coil methods to actually compute stuff
  • Throw error if objectives not built before optimization - should throw deprecation warning now
  • coils each have params method to get single vector of all their parameters
  • also have method to parse their own params into sub-vectors (eg x -> Rn, Zn, current)
  • move Objective.parse_args to Equilibrium as a way for it to unpack its own arguments
  • Objective.parse_args should only split full x into pieces for each optimizeable object - equilibirum, coils etc take it from there
  • All coils must be in a single overall Coilset (coilset can be made up of sub-coilsets)
  • Coilset defines unique ordering for coils, allowing us to line up coils in state vector with constraints that apply to them.

TODO:

@dpanici
Copy link
Collaborator

dpanici commented Jun 25, 2024

Basically resolved

@dpanici dpanici closed this as completed Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants