maybe_add_self_consistency doesn't work for single-stage optimization

[ddudt]

The optimizer only calls maybe_add_self_consistency if the objective is not a ProximalProjection. This means it will not get called in single-stage optimization, and the corresponding curve constraints will not be applied.

A possible solution would be to split maybe_add_self_consistency into two separate functions: one for constraints applied to the Equilibrium and another for all other things. The former would still only be applied when the objective is not a ProximalProjection, but the latter would always get called for all optimizations. This is because the proximal optimizer has special logic specific to equilibria.

Obviously the user can manually add them for now to make this work.

[dpanici]

#1236 should take this into account

[dpanici]

DESC/desc/optimize/optimizer.py

Line 212 in a9f9ae8

if not isinstance(objective, ProximalProjection):

I think just swapping the if and the for loop here and adding a logical for if t is an Equilibrium should be enough.