Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Seperate sky colour from fog colour #942

Open
careeoki opened this issue Jan 16, 2025 · 5 comments
Open

Seperate sky colour from fog colour #942

careeoki opened this issue Jan 16, 2025 · 5 comments
Labels
enhancement a new feature or improvement experimental a feature or idea that will require lots of experimentation graphics
Milestone
Long-Term Goals

Comments

@careeoki
Copy link
Contributor

Currently, setting a biome's fogColor changes the color of the sky as well, which is not ideal for surface biomes.

related: #60 #474
@ikabod-kee ikabod-kee added enhancement a new feature or improvement graphics labels Jan 16, 2025
@ikabod-kee ikabod-kee added this to the Long-Term Goals milestone Jan 16, 2025
@ikabod-kee
Copy link
Collaborator

Honestly, volumetric fog outdoes biome fog in that prospect. It's too bad it glows in the dark and has some buggy rendering issues at the moment.

@careeoki
Copy link
Contributor Author

It's also not very performant.

@ikabod-kee
Copy link
Collaborator

Fog definitely needs a re-write at some point.

@IntegratedQuantum
Copy link
Member

Fog definitely needs a re-write at some point.

Like I said many times, I don't think it really is possible to get any more features into the fog without restricting ourselves to certain hardware, or using raytracing.

@IntegratedQuantum IntegratedQuantum added the experimental a feature or idea that will require lots of experimentation label Jan 17, 2025
@IntegratedQuantum
Copy link
Member

The difficult problem with having different fog and sky colors is that distant terrain in fog vs distant sky will look distinctly different.

The best solution would be to have a density gradient in the fog,so that it gets denser near the ground, but I don't know if we can pull that off without breaking cave fog.

@IntegratedQuantum IntegratedQuantum mentioned this issue Jan 25, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement a new feature or improvement experimental a feature or idea that will require lots of experimentation graphics
Projects
None yet
Milestone
Long-Term Goals
Development

No branches or pull requests
3 participants
@IntegratedQuantum @careeoki @ikabod-kee