Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Collections erroneously claim that you cannot mix collection configurations #3537

Open
dgovil opened this issue Feb 20, 2025 · 4 comments

Comments

@dgovil
Copy link
Collaborator

dgovil commented Feb 20, 2025

The Collections and Patterns documentation claims that Note that you cannot mix collection configuration. We believe this is incorrect and this note should be removed to align with current USD behaviour.

We find that this is note is not true in USD 25.2. USD 25.2 allows for the mixing of these two types.

A sample setup is included here to reproduce the output below. test.py will generate the JSON, whereas diff.py will create a diff output.
collectionsTest.zip

The output here is generated between USD 24.3 and USD 25.2, and shows how the results of the collection have changed. This shows the difference in collection behaviour between the two versions. I did not test versions in between. We prefer the new behaviour for what it's worth.

- means the item was in 24.3 but not in 25.2. + means it is new in 25.2.

/cornell/collections/root_expression
	- /


/cornell/collections/root_includes
	- /


/cornell/collections/root_excludes
	+ /cornell/assets
	+ /cornell/collections/root_includes
	+ /cornell/assets/left
	+ /cornell/lookdev/green
	+ /cornell/assets/right
	+ /cornell/collections
	+ /cornell/assets/top
	+ /cornell/collections/expression_includes_excludes
	+ /cornell/lookdev/grey
	+ /cornell/lookdev/grey/shader
	+ /cornell/collections/root_excludes
	+ /cornell/lookdev/red/shader
	+ /cornell/lookdev
	+ /cornell/assets/back
	+ /cornell
	+ /cornell/collections/expression_excludes
	+ /cornell/assets/bottom
	+ /cornell/lookdev/red
	+ /cornell/camera
	+ /cornell/assets/rectlight
	+ /cornell/lookdev/green/shader
	+ /cornell/collections/root_includes_excludes
	+ /cornell/collections/root_expression
	+ /cornell/assets/right_box
	+ /cornell/collections/expression_includes


/cornell/collections/root_includes_excludes
	+ /cornell/collections/root_includes
	+ /cornell/lookdev/green
	+ /cornell/collections
	+ /cornell/collections/expression_includes_excludes
	+ /cornell/lookdev/grey
	+ /cornell/lookdev/grey/shader
	+ /cornell/collections/root_excludes
	+ /cornell/lookdev/red/shader
	+ /cornell/lookdev
	+ /cornell
	+ /cornell/collections/expression_excludes
	+ /cornell/lookdev/red
	+ /cornell/camera
	+ /cornell/lookdev/green/shader
	+ /cornell/collections/root_includes_excludes
	+ /cornell/collections/root_expression
	+ /cornell/collections/expression_includes


/cornell/collections/expression_excludes
	- /cornell/collections/root_includes
	- /cornell/lookdev/green
	- /cornell/collections
	- /cornell/collections/expression_includes
	- /cornell/collections/expression_includes_excludes
	- /cornell/lookdev/grey
	- /cornell/lookdev/grey/shader
	- /cornell/collections/root_excludes
	- /cornell/lookdev
	- /cornell/collections/expression_excludes
	- /cornell/lookdev/red
	- /cornell/lookdev/green/shader
	- /cornell/collections/root_includes_excludes
	- /cornell/collections/root_expression
	- /cornell/lookdev/red/shader
@spiffmon
Copy link
Member

Hi @dgovil , to the best of our knowledge, the documentation is correct, and if both are authored on a prim, only the relationship-based description will be consulted. There were, however, a series of bug fixes throughout 2024 that resulted in membershipExpressions making more matches than they previously did.

@spiffmon
Copy link
Member

Ah! Consulting @gitamohr , there is an open bug that is likely responsible for what you are seeing. A fix is IP.

@dgovil
Copy link
Collaborator Author

dgovil commented Feb 21, 2025

Ah so the current behaviour is incorrect. That's good to know. Thanks.

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10689

(This is an automated message. See here for more information.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants