Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPI-1101 Setup CI #8

Merged
merged 1 commit into from
Apr 10, 2024
Merged

PPI-1101 Setup CI #8

merged 1 commit into from
Apr 10, 2024

Conversation

auto200
Copy link
Contributor

@auto200 auto200 commented Apr 5, 2024

Changes compared to other packages:

on-push:

  • do not trigger workflow twice on pull requests

main:

  • remove unused workflow_dispatch
  • publish package in a single job so we don't have to upload artifacts between jobs and depend on each other
  • don't use cache - we can fit within billable minute without it
  • package.json as a single source of truth about version number - avoid situations like with https://github.com/PiwikPRO/ngx-piwik-pro/ where version in package.json and release version are out of sync

@auto200 auto200 marked this pull request as ready for review April 5, 2024 09:20
@auto200 auto200 marked this pull request as draft April 5, 2024 09:21
@auto200 auto200 force-pushed the PPI-1101-setup-ci branch 5 times, most recently from be9e35f to 3d9305c Compare April 5, 2024 09:36
@auto200 auto200 self-assigned this Apr 5, 2024
@auto200 auto200 force-pushed the PPI-1101-setup-ci branch 6 times, most recently from 4ad3c7c to 0af77da Compare April 8, 2024 13:40
@auto200 auto200 marked this pull request as ready for review April 9, 2024 07:27
@auto200 auto200 requested review from lysy-vlc and danieltwork April 9, 2024 07:27
@auto200 auto200 force-pushed the PPI-1101-setup-ci branch from 0af77da to 5e903ea Compare April 9, 2024 08:32
@auto200 auto200 mentioned this pull request Apr 9, 2024
@auto200 auto200 merged commit ab9ada4 into master Apr 10, 2024
1 check passed
@auto200 auto200 deleted the PPI-1101-setup-ci branch April 10, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants