FieldSettings not being passed to field collection region.

[sit-harry]

Hi there!

It looks like field setting attributes aren't being passed to the field whenever it is a single field collection.

If we have the below example...

[PageType(Title = "Standard page")]
public class StandardPage : Page<StandardPage>
{
    [Region]
    [StringFieldSettings(DefaultValue = "Hello World!")]
    public List<StringField> Fields { get; set; }

    [Region]
    public TestRegion TestRegion { get; set; }
}

public class TestRegion
{
    [Field]
    public StringField RegularStringField { get; set; }

    [Field]
    [StringFieldSettings(DefaultValue = "Hello World!")]
    public StringField FancyStringField { get; set; }
}

The FancyStringField works as expected, with the settings being pushed through to the field.

However, with the Fields region, the settings aren't being pushed through.

It looks like the settings needs to be added to the default ContentTypeField here and then pulled through here.

Will try to get a PR together soon, but let me know if I'm missing anything here, thanks :)

[tidyui]

I simply just don’t think this case is covered by the settings. I’ll tag this as a feature request!

[tidyui]

Fixed as of #2054