Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

HideSideBar just dead #4

Open
naruko-hstk opened this issue Feb 12, 2022 · 6 comments
Open

HideSideBar just dead #4

naruko-hstk opened this issue Feb 12, 2022 · 6 comments

Comments

@naruko-hstk
Copy link

image

@mwyschan
Copy link

mwyschan commented Feb 16, 2022

I managed to fix it by changing two functions in the code:

    const sidebarSelector = createSelector(
        // BdApi.findModuleByProps("hasNotice").sidebar
		BdApi.findModuleByProps("guilds").sidebar
    );
    const guildBarSelector = createSelector(
        // BdApi.findModuleByProps("hasNotice").guilds
		BdApi.findModuleByProps("guilds").guilds
    );

Hope that helps.

Edit: made a PR

@Pieloaf
Copy link
Owner

Pieloaf commented Feb 17, 2022

yo thank you so much for that, @Accelyte Sorry been super busy lately so haven't had time to look after it, well give it a quick test and merge

@Pieloaf
Copy link
Owner

Pieloaf commented Feb 17, 2022

@YuuJinS should be fixed now

@IamNickerson
Copy link

IamNickerson commented Feb 17, 2022

Hidesidebar PLUGIN IS BACK BOIS

@Pieloaf
Copy link
Owner

Pieloaf commented Feb 17, 2022

Did a bit more testing with it when I got home from uni and it's not completely fixed 🙃 I assumed the fix wouldn't be a permanent solution considering I was selecting an exact index from an array and as expected it broke when I first opened discord again... but once everything fully loaded calling findallmodules returned the two elements as expected and it worked again but yeah it's not a permanent fix :/ but at least the hot key is working ig

@mwyschan
Copy link

mwyschan commented Feb 18, 2022

If you change BdApi.findAllModules(m => m.sidebar)[1].sidebar to BdApi.findAllModules(m => m.guilds)[1].sidebar, it starts working again. Seems like the sidebarcomponent is tied to the guildscomponent.

Edit: updated the PR to include new changes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants