From 04be6660bab8dff04b8c80712472ac21b8509788 Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Fri, 6 Jan 2023 16:26:50 +0100 Subject: [PATCH 1/3] Enable Checkstyles `JavadocStyleCheck` --- pom.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/pom.xml b/pom.xml index c0574a1fc3..140a9e8741 100644 --- a/pom.xml +++ b/pom.xml @@ -710,6 +710,7 @@ + From 37f5b3c937f2c35e60bf20ff55bee596a5c298a6 Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Mon, 23 Jan 2023 10:35:21 +0100 Subject: [PATCH 2/3] Enable `checkEmptyJavadoc` --- .../errorprone/bugpatterns/PrimitiveComparisonTest.java | 2 ++ pom.xml | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java b/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java index e205fb1c19..87e34414d6 100644 --- a/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java +++ b/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java @@ -12,6 +12,8 @@ // XXX: Can we perhaps work-around this by describing the fixes in reverse order? final class PrimitiveComparisonTest { /** + * Identification test for primitive {@code byte} comparisons. + * * @implNote The logic for {@code char} and {@code short} is exactly analogous to the {@code byte} * case. */ diff --git a/pom.xml b/pom.xml index 140a9e8741..6143e1d6ce 100644 --- a/pom.xml +++ b/pom.xml @@ -710,7 +710,9 @@ - + + + From 48d0ae71d5a0b70a5ad9ad1bf774f4801d3766a9 Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Mon, 23 Jan 2023 10:57:36 +0100 Subject: [PATCH 3/3] Apply suggestion --- .../picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java b/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java index 87e34414d6..3362b95b44 100644 --- a/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java +++ b/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/PrimitiveComparisonTest.java @@ -12,7 +12,7 @@ // XXX: Can we perhaps work-around this by describing the fixes in reverse order? final class PrimitiveComparisonTest { /** - * Identification test for primitive {@code byte} comparisons. + * Tests the identification of {@code byte} comparisons for which boxing can be avoided. * * @implNote The logic for {@code char} and {@code short} is exactly analogous to the {@code byte} * case.