From 13499bdab37c95d9360d2febeb9df46be118e135 Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Tue, 20 Sep 2022 09:57:12 +0200 Subject: [PATCH 1/2] Update Javadoc to reference #2706 missing type arguments --- .../refastertemplates/ImmutableListMultimapTemplates.java | 4 ++-- .../refastertemplates/ImmutableListTemplates.java | 4 ++-- .../refastertemplates/ImmutableMapTemplates.java | 4 ++-- .../refastertemplates/ImmutableMultisetTemplates.java | 4 ++-- .../refastertemplates/ImmutableSetMultimapTemplates.java | 4 ++-- .../refastertemplates/ImmutableSetTemplates.java | 4 ++-- .../refastertemplates/ImmutableSortedMapTemplates.java | 8 ++++---- 7 files changed, 16 insertions(+), 16 deletions(-) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java index 2ef8696f70..39e673bd20 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java @@ -33,8 +33,8 @@ private ImmutableListMultimapTemplates() {} * Prefer {@link ImmutableListMultimap#builder()} over the associated constructor on constructions * that produce a less-specific type. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableListMultimapBuilder { @BeforeTemplate ImmutableMultimap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java index 2b73212db7..ab6586a025 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java @@ -26,8 +26,8 @@ final class ImmutableListTemplates { private ImmutableListTemplates() {} /** Prefer {@link ImmutableList#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableListBuilder { @BeforeTemplate ImmutableList.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java index fedbc9bfb7..d8183b736e 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java @@ -27,8 +27,8 @@ final class ImmutableMapTemplates { private ImmutableMapTemplates() {} /** Prefer {@link ImmutableMap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableMapBuilder { @BeforeTemplate ImmutableMap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java index 0bfb8ecdbd..18a6d9d278 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java @@ -19,8 +19,8 @@ final class ImmutableMultisetTemplates { private ImmutableMultisetTemplates() {} /** Prefer {@link ImmutableMultiset#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableMultisetBuilder { @BeforeTemplate ImmutableMultiset.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java index fa4251e82a..18c871a2d9 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java @@ -27,8 +27,8 @@ final class ImmutableSetMultimapTemplates { private ImmutableSetMultimapTemplates() {} /** Prefer {@link ImmutableSetMultimap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSetMultimapBuilder { @BeforeTemplate ImmutableSetMultimap.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java index 2af6ec74dc..d1ff1069f8 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java @@ -23,8 +23,8 @@ final class ImmutableSetTemplates { private ImmutableSetTemplates() {} /** Prefer {@link ImmutableSet#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSetBuilder { @BeforeTemplate ImmutableSet.Builder before() { diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java index f112dcb551..fefd1bdd11 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java @@ -35,8 +35,8 @@ ImmutableSortedMap.Builder after(Comparator cmp) { * Prefer {@link ImmutableSortedMap#naturalOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSortedMapNaturalOrderBuilder, V> { @BeforeTemplate ImmutableSortedMap.Builder before() { @@ -53,8 +53,8 @@ ImmutableSortedMap.Builder after() { * Prefer {@link ImmutableSortedMap#reverseOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. Anything - // we can do about that? + // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // https://github.com/google/error-prone/pull/2706. static final class ImmutableSortedMapReverseOrderBuilder, V> { @BeforeTemplate ImmutableSortedMap.Builder before() { From 3da92da1c9bc392258d5640e262e9ffcafadf39c Mon Sep 17 00:00:00 2001 From: Stephan Schroevers Date: Tue, 20 Sep 2022 22:37:47 +0200 Subject: [PATCH 2/2] OCD --- .../refastertemplates/ImmutableListMultimapTemplates.java | 2 +- .../errorprone/refastertemplates/ImmutableListTemplates.java | 2 +- .../errorprone/refastertemplates/ImmutableMapTemplates.java | 2 +- .../refastertemplates/ImmutableMultisetTemplates.java | 2 +- .../refastertemplates/ImmutableSetMultimapTemplates.java | 2 +- .../errorprone/refastertemplates/ImmutableSetTemplates.java | 2 +- .../refastertemplates/ImmutableSortedMapTemplates.java | 4 ++-- 7 files changed, 8 insertions(+), 8 deletions(-) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java index 39e673bd20..0174bae0b1 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListMultimapTemplates.java @@ -33,7 +33,7 @@ private ImmutableListMultimapTemplates() {} * Prefer {@link ImmutableListMultimap#builder()} over the associated constructor on constructions * that produce a less-specific type. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableListMultimapBuilder { @BeforeTemplate diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java index ab6586a025..711426361b 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableListTemplates.java @@ -26,7 +26,7 @@ final class ImmutableListTemplates { private ImmutableListTemplates() {} /** Prefer {@link ImmutableList#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableListBuilder { @BeforeTemplate diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java index d8183b736e..8429e1b3d5 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMapTemplates.java @@ -27,7 +27,7 @@ final class ImmutableMapTemplates { private ImmutableMapTemplates() {} /** Prefer {@link ImmutableMap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableMapBuilder { @BeforeTemplate diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java index 18a6d9d278..d60264965f 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableMultisetTemplates.java @@ -19,7 +19,7 @@ final class ImmutableMultisetTemplates { private ImmutableMultisetTemplates() {} /** Prefer {@link ImmutableMultiset#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableMultisetBuilder { @BeforeTemplate diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java index 18c871a2d9..ed991be8ef 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetMultimapTemplates.java @@ -27,7 +27,7 @@ final class ImmutableSetMultimapTemplates { private ImmutableSetMultimapTemplates() {} /** Prefer {@link ImmutableSetMultimap#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableSetMultimapBuilder { @BeforeTemplate diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java index d1ff1069f8..a3ef63e71f 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSetTemplates.java @@ -23,7 +23,7 @@ final class ImmutableSetTemplates { private ImmutableSetTemplates() {} /** Prefer {@link ImmutableSet#builder()} over the associated constructor. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableSetBuilder { @BeforeTemplate diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java index fefd1bdd11..e5e265d684 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ImmutableSortedMapTemplates.java @@ -35,7 +35,7 @@ ImmutableSortedMap.Builder after(Comparator cmp) { * Prefer {@link ImmutableSortedMap#naturalOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableSortedMapNaturalOrderBuilder, V> { @BeforeTemplate @@ -53,7 +53,7 @@ ImmutableSortedMap.Builder after() { * Prefer {@link ImmutableSortedMap#reverseOrder()} over the alternative that requires explicitly * providing the {@link Comparator}. */ - // XXX: This drops generic type information, sometimes leading to non-compilable code. See: + // XXX: This drops generic type information, sometimes leading to non-compilable code. See // https://github.com/google/error-prone/pull/2706. static final class ImmutableSortedMapReverseOrderBuilder, V> { @BeforeTemplate