Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive against Sentry-Trace #315

Closed
2 tasks done
TomBeckett opened this issue Oct 25, 2022 · 4 comments · Fixed by #308
Closed
2 tasks done

False positive against Sentry-Trace #315

TomBeckett opened this issue Oct 25, 2022 · 4 comments · Fixed by #308
Labels
bug Something isn't working
Milestone

Comments

@TomBeckett
Copy link

TomBeckett commented Oct 25, 2022

Describe the bug

  • I have verified that the issue is reproducible against the latest version
    of the project.
  • I have searched through existing issues to verify that this issue is not
    already known.

Minimal Reproducible Example

    @SentrySpan
    @Transactional
    @Scheduled(cron = "@hourly")
    @SchedulerLock(name = SYNC_EXERCISES_LOCK_NAME, lockAtLeastFor = "2m", lockAtMostFor = "10m")
    @SentryTransaction(operation = "task")

Produces:

[ERROR]     (see https://error-prone.picnic.tech/bugpatterns/ScheduledTransactionTrace)
[ERROR]   Did you mean '@Trace(dispatcher = true)@SentrySpan'?

Expected behavior

No error should be present. We use Sentry (not New Relic).

Setup

  • Mac OS latest.
  • Java version 19.0.1
  • Error Prone Latest
  • Error Prone Support Latest

Additional context

None.

@TomBeckett TomBeckett added the bug Something isn't working label Oct 25, 2022
@rickie
Copy link
Member

rickie commented Oct 25, 2022

Hey @TomBeckett, thanks for opening this issue!

Good news, we are already working on a fix for that! For context, see #308. There we add an extra check to make sure that an error is thrown only if New Relic is on the classpath. In other words, it should fix your case.

For now, I would suggest to turn off the check as is explained in our documentation.

We will let you know once a fix for this is out.

@rickie rickie added this to the 0.5.0 milestone Oct 25, 2022
@TomBeckett
Copy link
Author

@rickie Awesome, thank you for the fast response. Is there any ETA on when this may be released?

I ask because I have the more issues/examples just like that thread and don't want to spam issues if they are coming soon 😄

@rickie
Copy link
Member

rickie commented Oct 25, 2022

I hope we can do a release ~this week (not making a hard promise though 👀).

Do you mean that you have more related issues or other issues that are not related to this one?
In the latter case, feel free to open more issues 😄.

@rickie
Copy link
Member

rickie commented Nov 1, 2022

@TomBeckett we released v0.5.0! So updating should solve the problem 😄. Let us know if you encounter any problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
2 participants