Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize assorted Refaster rules #1481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 26, 2024

Suggested commit message:

Generalize assorted Refaster rules (#1481)

This was done manually, with the help of IntelliJ IDEA's "Parameter type may be weakened" inspection. I considered writing an Error Prone check for this, but that'd be quite involved, requiring more effort than I'm willing to spend at this time.

Copy link

Looks good. No mutations were possible for these changes.
Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

I considered writing an Error Prone check for this, but that'd be quite involved, requiring more effort than I'm willing to spend at this time.

I can help 🙋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants