Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JUnitMethodDeclaration method rename heuristics #1476

Merged

Conversation

Stephan202
Copy link
Member

@Stephan202 Stephan202 commented Dec 22, 2024

Suggested commit message:

Improve `JUnitMethodDeclaration` method rename heuristics (#1476)

These changes make it less likely that the check suggests a method
rename that would yield invalid code.

See also this comment: this change resolves a bug identified using the upcoming Prometheus Java Client integration test.

These changes make it less likely that the check suggests a method
rename that would yield invalid code.
Copy link

Looks good. All 23 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.utils.ConflictDetection 0 6
🎉tech.picnic.errorprone.utils.ConflictDetection$1 0 17

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link

Looks good. All 22 mutations in this change were killed.

class surviving killed
🎉tech.picnic.errorprone.utils.ConflictDetection 0 6
🎉tech.picnic.errorprone.utils.ConflictDetection$1 0 16

Mutation testing report by Pitest. Review any surviving mutants by inspecting the line comments under Files changed.

Copy link
Contributor

@mohamedsamehsalah mohamedsamehsalah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@rickie rickie merged commit d316e8a into master Dec 23, 2024
16 checks passed
@rickie rickie deleted the sschroevers/improve-method-renaming-conflict-resolution branch December 23, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants