Introduce AssertThatThrownBy*ExceptionRootCauseHasMessage Refaster rules
#1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickie
changed the title
AssertThat{*}ExceptionRootCauseHasMessage Refaster rulesAssertThatThrownBy{*}RootCauseHasMessage Refaster rules
|
Looks good. No mutations were possible for these changes. |
Stephan202
changed the title
AssertThatThrownBy{*}RootCauseHasMessage Refaster rulesAssertThatThrownBy*ExceptionRootCauseHasMessage Refaster rules
Stephan202
approved these changes
Dec 21, 2024
Comment on lines
+575
to
+599
| static final class AssertThatThrownByRootCauseHasMessage { | ||
| @BeforeTemplate | ||
| @SuppressWarnings("AssertThatThrownBy" /* This is a more specific template. */) | ||
| AbstractObjectAssert<?, ?> before( | ||
| ThrowingCallable throwingCallable, | ||
| Class<? extends Throwable> exceptionType, | ||
| String message) { | ||
| return assertThatExceptionOfType(exceptionType) | ||
| .isThrownBy(throwingCallable) | ||
| .havingRootCause() | ||
| .withMessage(message); | ||
| } | ||
|
|
||
| @AfterTemplate | ||
| @UseImportPolicy(STATIC_IMPORT_ALWAYS) | ||
| AbstractObjectAssert<?, ?> after( | ||
| ThrowingCallable throwingCallable, | ||
| Class<? extends Throwable> exceptionType, | ||
| String message) { | ||
| return assertThatThrownBy(throwingCallable) | ||
| .isInstanceOf(exceptionType) | ||
| .rootCause() | ||
| .hasMessage(message); | ||
| } | ||
| } |
There was a problem hiding this comment.
We should make the return types more explicit, and replace ? extends Throwable with a shared type variable T, but that applies to many rules in this class, so: for another time. (Ideally both these steps are automated.)
Stephan202
force-pushed
the
rossendrijver/assertj_having_rootcause
branch
from
e0b0007 to
ac0cdbf
Compare
|
Looks good. No mutations were possible for these changes. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to get rid of the following part of the
init-patchof the new IT: https://github.com/PicnicSupermarket/error-prone-support/pull/1468/files#diff-6b99a1fb957cc4c8081a8a95423c965335a67c526f4b5b634aafa0d6912dc4dcR61.Not sure about the * part in the title, let me know what options are :D.