From d3d6c930ed2c901fa2ee5d2a8a1e896cc589aa8a Mon Sep 17 00:00:00 2001 From: Stephan Schroevers Date: Fri, 2 Dec 2022 21:59:46 +0100 Subject: [PATCH] Expand details around follow-up work --- .../picnic/errorprone/bugpatterns/ImplicitLocaleUsage.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitLocaleUsage.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitLocaleUsage.java index d0fdd43993..1af47c3a22 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitLocaleUsage.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitLocaleUsage.java @@ -23,7 +23,10 @@ * A {@link BugChecker} that flags calls to {@link String#toLowerCase()} and {@link * String#toUpperCase()}, as these methods implicitly rely on the environment's default locale. */ -// XXX: Also flag `String::toLowerCase` and `String::toUpperCase` method references. +// XXX: Also flag `String::toLowerCase` and `String::toUpperCase` method references. For these cases +// the suggested fix should introduce a lambda expression with a parameter of which the name does +// not coincide with the name of an existing variable name. Such functionality should likely be +// introduced in a utility class. @AutoService(BugChecker.class) @BugPattern( summary = "Specify a `Locale` when calling `String#to{Lower,Upper}Case`",