From c3f6d154631ea0e212d9f8ab782ca2d35baac279 Mon Sep 17 00:00:00 2001
From: Rick Ossendrijver <rick.ossendrijver@gmail.com>
Date: Tue, 4 Oct 2022 10:29:04 +0200
Subject: [PATCH] Suggestions

---
 .../refastertemplates/ReactorTemplates.java   | 24 +++++++++----------
 .../ReactorTemplatesTestInput.java            |  8 +++----
 .../ReactorTemplatesTestOutput.java           |  8 +++----
 3 files changed, 20 insertions(+), 20 deletions(-)

diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ReactorTemplates.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ReactorTemplates.java
index bff2528c1b..caf804c465 100644
--- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ReactorTemplates.java
+++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/refastertemplates/ReactorTemplates.java
@@ -271,29 +271,29 @@ Flux<S> after(Flux<T> flux) {
     }
   }
 
-  /** Prefer {@link Flux#onErrorComplete()} over more contrived alternatives */
-  static final class FluxOnErrorComplete<T> {
+  /** Prefer {@link Mono#onErrorComplete()} over more contrived alternatives. */
+  static final class MonoOnErrorComplete<T> {
     @BeforeTemplate
-    Flux<T> before(Flux<T> flux) {
-      return flux.onErrorResume(e -> Flux.empty());
+    Mono<T> before(Mono<T> mono) {
+      return mono.onErrorResume(e -> Mono.empty());
     }
 
     @AfterTemplate
-    Flux<T> after(Flux<T> flux) {
-      return flux.onErrorComplete();
+    Mono<T> after(Mono<T> mono) {
+      return mono.onErrorComplete();
     }
   }
 
-  /** Prefer {@link Mono#onErrorComplete()} over more contrived alternatives */
-  static final class MonoOnErrorComplete<T> {
+  /** Prefer {@link Flux#onErrorComplete()} over more contrived alternatives. */
+  static final class FluxOnErrorComplete<T> {
     @BeforeTemplate
-    Mono<T> before(Mono<T> mono) {
-      return mono.onErrorResume(e -> Mono.empty());
+    Flux<T> before(Flux<T> flux) {
+      return flux.onErrorResume(e -> Flux.empty());
     }
 
     @AfterTemplate
-    Mono<T> after(Mono<T> mono) {
-      return mono.onErrorComplete();
+    Flux<T> after(Flux<T> flux) {
+      return flux.onErrorComplete();
     }
   }
 
diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestInput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestInput.java
index 573b6485d4..d44ea29e77 100644
--- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestInput.java
+++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestInput.java
@@ -95,12 +95,12 @@ Flux<Number> testFluxCast() {
     return Flux.just(1).map(Number.class::cast);
   }
 
-  Flux<Object> testFluxOnErrorComplete() {
-    return Flux.error(new IllegalStateException()).onErrorResume(e -> Flux.empty());
+  Mono<Integer> testMonoOnErrorComplete() {
+    return Mono.just(1).onErrorResume(e -> Mono.empty());
   }
 
-  Mono<Object> testMonoOnErrorComplete() {
-    return Mono.error(new IllegalStateException()).onErrorResume(e -> Mono.empty());
+  Flux<Integer> testFluxOnErrorComplete() {
+    return Flux.just(1).onErrorResume(e -> Flux.empty());
   }
 
   ImmutableSet<PublisherProbe<Void>> testPublisherProbeEmpty() {
diff --git a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestOutput.java b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestOutput.java
index 482abe347a..72edb92164 100644
--- a/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestOutput.java
+++ b/error-prone-contrib/src/test/resources/tech/picnic/errorprone/refastertemplates/ReactorTemplatesTestOutput.java
@@ -94,12 +94,12 @@ Flux<Number> testFluxCast() {
     return Flux.just(1).cast(Number.class);
   }
 
-  Flux<Object> testFluxOnErrorComplete() {
-    return Flux.error(new IllegalStateException()).onErrorComplete();
+  Mono<Integer> testMonoOnErrorComplete() {
+    return Mono.just(1).onErrorComplete();
   }
 
-  Mono<Object> testMonoOnErrorComplete() {
-    return Mono.error(new IllegalStateException()).onErrorComplete();
+  Flux<Integer> testFluxOnErrorComplete() {
+    return Flux.just(1).onErrorComplete();
   }
 
   ImmutableSet<PublisherProbe<Void>> testPublisherProbeEmpty() {