From aa7836093bcd4c1d0466bb061b40364bc701b90c Mon Sep 17 00:00:00 2001
From: Stephan Schroevers <stephan.schroevers@teampicnic.com>
Date: Fri, 28 Apr 2023 17:01:39 +0200
Subject: [PATCH] Sonar build improvement

---
 .github/workflows/sonarcloud.yml | 2 +-
 pom.xml                          | 6 ++++++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/sonarcloud.yml b/.github/workflows/sonarcloud.yml
index 32afe06e4aa..5df6b84646c 100644
--- a/.github/workflows/sonarcloud.yml
+++ b/.github/workflows/sonarcloud.yml
@@ -33,4 +33,4 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
-        run: mvn -T1C jacoco:prepare-agent verify jacoco:report sonar:sonar -Dversion.jdk.runtime=17 -Dverification.skip -Dsonar.projectKey=PicnicSupermarket_error-prone-support
+        run: mvn -T1C jacoco:prepare-agent verify jacoco:report sonar:sonar -Dverification.skip -Dsonar.projectKey=PicnicSupermarket_error-prone-support
diff --git a/pom.xml b/pom.xml
index 8a351e3e5b8..56117374032 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1858,6 +1858,12 @@
             <id>sonar</id>
             <properties>
                 <maven.test.failure.ignore>true</maven.test.failure.ignore>
+                <!-- Normal builds use Jabel to target an older JDK version
+                than would normally supported given the language features used,
+                but this causes Sonar to report parse errors. So for Sonar
+                builds we target a JDK version that is properly compatible with
+                the source code.-->
+                <version.jdk.runtime>${version.jdk.source}</version.jdk.runtime>
             </properties>
         </profile>
         <profile>