From a60c4d1c9eb3b95ef39835ccec3b7881bfb7614b Mon Sep 17 00:00:00 2001 From: Rick Ossendrijver Date: Mon, 20 Feb 2023 09:15:26 +0100 Subject: [PATCH] `s/ImplicitBlockingFlux/FluxImplicitBlock/` --- ...citBlockingFlux.java => FluxImplicitBlock.java} | 8 ++++---- ...ingFluxTest.java => FluxImplicitBlockTest.java} | 14 +++++++------- 2 files changed, 11 insertions(+), 11 deletions(-) rename error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/{ImplicitBlockingFlux.java => FluxImplicitBlock.java} (94%) rename error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/{ImplicitBlockingFluxTest.java => FluxImplicitBlockTest.java} (92%) diff --git a/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitBlockingFlux.java b/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/FluxImplicitBlock.java similarity index 94% rename from error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitBlockingFlux.java rename to error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/FluxImplicitBlock.java index 8f16f6f8f81..17c8098c09b 100644 --- a/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/ImplicitBlockingFlux.java +++ b/error-prone-contrib/src/main/java/tech/picnic/errorprone/bugpatterns/FluxImplicitBlock.java @@ -37,11 +37,11 @@ @AutoService(BugChecker.class) @BugPattern( summary = "Avoid iterating over `Flux`es in an implicitly blocking manner", - link = BUG_PATTERNS_BASE_URL + "ImplicitBlockingFlux", + link = BUG_PATTERNS_BASE_URL + "FluxImplicitBlock", linkType = CUSTOM, severity = WARNING, tags = {CONCURRENCY, PERFORMANCE}) -public final class ImplicitBlockingFlux extends BugChecker implements MethodInvocationTreeMatcher { +public final class FluxImplicitBlock extends BugChecker implements MethodInvocationTreeMatcher { private static final long serialVersionUID = 1L; private static final Matcher FLUX_WITH_IMPLICIT_BLOCK = instanceMethod() @@ -50,8 +50,8 @@ public final class ImplicitBlockingFlux extends BugChecker implements MethodInvo .withNoParameters(); private static final Supplier STREAM = Suppliers.typeFromString(Stream.class.getName()); - /** Instantiates a new {@link ImplicitBlockingFlux} instance. */ - public ImplicitBlockingFlux() {} + /** Instantiates a new {@link FluxImplicitBlock} instance. */ + public FluxImplicitBlock() {} @Override public Description matchMethodInvocation(MethodInvocationTree tree, VisitorState state) { diff --git a/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/ImplicitBlockingFluxTest.java b/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/FluxImplicitBlockTest.java similarity index 92% rename from error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/ImplicitBlockingFluxTest.java rename to error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/FluxImplicitBlockTest.java index e3a1cd9beef..6390b2d0418 100644 --- a/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/ImplicitBlockingFluxTest.java +++ b/error-prone-contrib/src/test/java/tech/picnic/errorprone/bugpatterns/FluxImplicitBlockTest.java @@ -14,10 +14,10 @@ import reactor.core.CorePublisher; import reactor.core.publisher.Flux; -final class ImplicitBlockingFluxTest { +final class FluxImplicitBlockTest { @Test void identification() { - CompilationTestHelper.newInstance(ImplicitBlockingFlux.class, getClass()) + CompilationTestHelper.newInstance(FluxImplicitBlock.class, getClass()) .expectErrorMessage( "X", and( @@ -61,7 +61,7 @@ void identification() { @Test void identificationWithoutGuavaOnClasspath() { - CompilationTestHelper.newInstance(ImplicitBlockingFlux.class, getClass()) + CompilationTestHelper.newInstance(FluxImplicitBlock.class, getClass()) .withClasspath(CorePublisher.class, Flux.class, Publisher.class) .expectErrorMessage("X", not(containsPattern("toImmutableList"))) .addSourceLines( @@ -81,7 +81,7 @@ void identificationWithoutGuavaOnClasspath() { @Test void replacementFirstSuggestedFix() { - BugCheckerRefactoringTestHelper.newInstance(ImplicitBlockingFlux.class, getClass()) + BugCheckerRefactoringTestHelper.newInstance(FluxImplicitBlock.class, getClass()) .addInputLines( "A.java", "import reactor.core.publisher.Flux;", @@ -97,7 +97,7 @@ void replacementFirstSuggestedFix() { "import reactor.core.publisher.Flux;", "", "class A {", - " @SuppressWarnings(\"ImplicitBlockingFlux\")", + " @SuppressWarnings(\"FluxImplicitBlock\")", " void m() {", " Flux.just(1).toIterable();", " Flux.just(2).toStream();", @@ -108,7 +108,7 @@ void replacementFirstSuggestedFix() { @Test void replacementSecondSuggestedFix() { - BugCheckerRefactoringTestHelper.newInstance(ImplicitBlockingFlux.class, getClass()) + BugCheckerRefactoringTestHelper.newInstance(FluxImplicitBlock.class, getClass()) .setFixChooser(SECOND) .addInputLines( "A.java", @@ -145,7 +145,7 @@ void replacementSecondSuggestedFix() { @Test void replacementThirdSuggestedFix() { - BugCheckerRefactoringTestHelper.newInstance(ImplicitBlockingFlux.class, getClass()) + BugCheckerRefactoringTestHelper.newInstance(FluxImplicitBlock.class, getClass()) .setFixChooser(THIRD) .addInputLines( "A.java",