From 702b58971b3cd2cffee7e2f8eb7c02dfadc8db5e Mon Sep 17 00:00:00 2001
From: Rick Ossendrijver <rick.ossendrijver@gmail.com>
Date: Wed, 28 Sep 2022 20:15:12 +0200
Subject: [PATCH] Suggestions

---
 .github/workflows/deploy-website.yaml | 11 ++++++-----
 generate-docs.sh                      |  3 +--
 website/Gemfile                       |  2 +-
 website/_config.yml                   |  2 +-
 website/_includes/head_custom.html    |  2 +-
 website/_sass/custom/custom.scss      |  4 ++--
 6 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/.github/workflows/deploy-website.yaml b/.github/workflows/deploy-website.yaml
index f294138ef54..fd2c0b515e0 100644
--- a/.github/workflows/deploy-website.yaml
+++ b/.github/workflows/deploy-website.yaml
@@ -1,4 +1,4 @@
-name: Update `error-prone.picnic.tech` website contents
+name: Update `error-prone.picnic.tech` website content
 on:
   push:
     branches: [$default-branch]
@@ -17,7 +17,7 @@ jobs:
       - name: Check out code
         uses: actions/checkout@v3.0.2
       - name: Configure Github Pages
-        uses: actions/configure-pages@v2.0.0
+        uses: actions/configure-pages@v2.1.1
       - name: Generate documentation
         run:  bash ./generate-docs.sh
       - name: Build website with Jekyll
@@ -25,8 +25,9 @@ jobs:
         with:
           source: website/
           destination: ./_site
-      - name: Upload website artifact
-        uses: actions/upload-pages-artifact@v1.0.3
+      - name: Upload website as artifact
+        uses: actions/upload-pages-artifact@v1.0.4
+
   deploy:
     environment:
       name: github-pages
@@ -36,4 +37,4 @@ jobs:
     steps:
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v1.0.9
+        uses: actions/deploy-pages@v1.2.1
diff --git a/generate-docs.sh b/generate-docs.sh
index 562f4d980a7..b3d0e3f8cf4 100755
--- a/generate-docs.sh
+++ b/generate-docs.sh
@@ -4,7 +4,7 @@ WEBSITE_FOLDER="website"
 HOMEPAGE="${WEBSITE_FOLDER}/index.md"
 
 configure() {
-    cd "$(git rev-parse --show-toplevel || echo .)"
+    cd "$(git rev-parse --show-toplevel || echo .)" || exit
     mkdir "${BUGPATTERN_FOLDER}" 2>/dev/null
     mkdir "${REFASTER_FOLDER}" 2>/dev/null
 }
@@ -29,6 +29,5 @@ EOF
     sed $SEDOPTION 's/srcset="website\//srcset="/g' ${HOMEPAGE}
 }
 
-# Do it
 configure
 generate_homepage
diff --git a/website/Gemfile b/website/Gemfile
index d5d1e8e2222..fe009842628 100644
--- a/website/Gemfile
+++ b/website/Gemfile
@@ -1,3 +1,3 @@
 source "https://rubygems.org"
 gem "github-pages", "~> 227"
-gem "rake", "~> 13.0" # Required for "just-the-docs" theme
+gem "rake", "~> 13.0" # Required for "just-the-docs" theme.
diff --git a/website/_config.yml b/website/_config.yml
index d5f4512b84e..304b0cdc99b 100644
--- a/website/_config.yml
+++ b/website/_config.yml
@@ -9,7 +9,7 @@ remote_theme: just-the-docs/just-the-docs
 plugins:
 - jekyll-remote-theme
 
-# Do not deploy through GitHub pages.
+# Do not deploy these files through GitHub pages.
 exclude:
   - Gemfile
   - Gemfile.lock
diff --git a/website/_includes/head_custom.html b/website/_includes/head_custom.html
index fc9e5f8aaf1..a2fc741ba55 100644
--- a/website/_includes/head_custom.html
+++ b/website/_includes/head_custom.html
@@ -10,7 +10,7 @@
 <meta name="theme-color" content="#ffffff">
 
 <!-- Support light and dark mode, as it's not natively supported.
-    See: https://github.com/just-the-docs/just-the-docs/issues/234 -->
+    See https://github.com/just-the-docs/just-the-docs/issues/234. -->
 <link rel="stylesheet" href="{{ '/assets/css/just-the-docs-light.css' | relative_url }}"
     media="(prefers-color-scheme: light)">
 <link rel="stylesheet" href="{{ '/assets/css/just-the-docs-dark.css' | relative_url }}"
diff --git a/website/_sass/custom/custom.scss b/website/_sass/custom/custom.scss
index 04d153d8ef7..60ad2422602 100644
--- a/website/_sass/custom/custom.scss
+++ b/website/_sass/custom/custom.scss
@@ -1,6 +1,6 @@
 // We should override $nav-width(-md), however this breaks code highlighting and other styles.
-// This appears an issue wrt the recommended way.
-// See: https://github.com/just-the-docs/just-the-docs/issues/982
+// This seems to be an issue for following the recommended approach.
+// See https://github.com/just-the-docs/just-the-docs/issues/982.
 @include mq(lg) {
     .side-bar {
         min-width: 400px;