From 4094d21094a3132eed35ac550c573871f938429f Mon Sep 17 00:00:00 2001 From: Pieter Dirk Soels Date: Thu, 15 Dec 2022 13:49:26 +0100 Subject: [PATCH] Use root `favicon.ico` As opposed to having a custom link to `/assets/images/favicon.ico`. --- .github/workflows/deploy-website.yaml | 2 +- website/_includes/head_custom.html | 1 - website/{assets/images => }/favicon.ico | Bin 3 files changed, 1 insertion(+), 2 deletions(-) rename website/{assets/images => }/favicon.ico (100%) diff --git a/.github/workflows/deploy-website.yaml b/.github/workflows/deploy-website.yaml index dec611db05a..2f2e7ad54a6 100644 --- a/.github/workflows/deploy-website.yaml +++ b/.github/workflows/deploy-website.yaml @@ -28,7 +28,7 @@ jobs: working-directory: ./website # XXX: Drop `--disable_external true` once we fully adopted the # "Refaster rules" terminology on our website and in the code. - run: bundle exec htmlproofer --disable_external true --check-external-hash false --ignore-urls "/favicon.ico" ./_site + run: bundle exec htmlproofer --disable_external true --check-external-hash false ./_site - name: Upload website as artifact uses: actions/upload-pages-artifact@v1.0.5 with: diff --git a/website/_includes/head_custom.html b/website/_includes/head_custom.html index 48d58e4cab4..e3033725a8e 100644 --- a/website/_includes/head_custom.html +++ b/website/_includes/head_custom.html @@ -4,7 +4,6 @@ - diff --git a/website/assets/images/favicon.ico b/website/favicon.ico similarity index 100% rename from website/assets/images/favicon.ico rename to website/favicon.ico