Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.4 compatibility #280

Closed
g105b opened this issue Oct 25, 2021 · 3 comments
Closed

PHP 7.4 compatibility #280

g105b opened this issue Oct 25, 2021 · 3 comments

Comments

@g105b
Copy link
Member

g105b commented Oct 25, 2021

This might feel like a step backwards, but as I'd like to keep the barrier to entry as low as possible to new developers, and a tiny percentage of Wordpress websites are running PHP 8, changing the code to support 7.4 seems like a logical step.

Thanks to @pagelab for his comments on this in #276.

I'm going to track the implementation details here as and when I get around to it.

@g105b
Copy link
Member Author

g105b commented Oct 25, 2021

First thing to note is that Bind Attributes will not work (as Attributes are a PHP 8 specific language feature). This might be acceptable though, as they are an advanced feature that isn't core to the implementation of DomTemplate. I'd have to test what sort of runtime exceptions are thrown in 7.4 if they are attempted to be used, and throw a more appropriate error message like "You are trying to use a feature that requires PHP 8".

@g105b
Copy link
Member Author

g105b commented Nov 15, 2021

While this is being implemented, introduce Github Actions matrix testing, like in phpgt/dom

@g105b
Copy link
Member Author

g105b commented Feb 20, 2023

Closing, because PHP.Gt's policy is to have the same support as the official PHP project, as per https://www.php.net/supported-versions.php

As of today, 8.0 is only receiving security updates so all repositories are only going to support 8.1 from now on. I wish I could, but it's not possible to put the extra work in to support old versions. Sorry if this disappoints anyone.

@g105b g105b closed this as completed Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant