Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function phorum_date() doesn't check if setlocale is successfully #916

Open
oricgn opened this issue Aug 7, 2015 · 0 comments
Open

Function phorum_date() doesn't check if setlocale is successfully #916

oricgn opened this issue Aug 7, 2015 · 0 comments

Comments

@oricgn
Copy link
Contributor

oricgn commented Aug 7, 2015

The function phorum_date() returns not expected formatted date/times when the local from the language file ($PHORUM['locale']) is not installed/generated in the operating system. In this case date/times are formatted with the default locale from the OS.

I think there should be a warning for the administrator of the forum.

At least as an additional hint in the language file but perhaps also as a 'system sanity check' (as part of the Language Support Check) or an event in the Event Logging Module.

It's easy to catch the return value from setlocale and compare it to $PHORUM['locale'].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant