Skip to content
This repository has been archived by the owner on Jan 12, 2024. It is now read-only.

[FeatureRequest] Generalize affine and grid transforms to support keys with different spatial size #37

Open
mibaumgartner opened this issue Feb 23, 2020 · 0 comments · May be fixed by #38
Labels
FeatureRequest Request for additional feature

Comments

@mibaumgartner
Copy link
Member

Description
The grid is only created for the first element in the batch. This behaviour should be generalised to support keys with different spatial size without introducing computation overhead (e.g. computing and augmenting a grid multiple times even though the keys have the same spatial size)

it should be save to ignore the number of channels and only focus on spatial size of the grid because pytorch does not use that anyway (even though affine_grid wants the number of channels) https://github.com/pytorch/pytorch/blob/74b65c32be68b15dc7c9e8bb62459efbfbde33d8/aten/src/ATen/native/AffineGridGenerator.cpp#L34-L62

@mibaumgartner mibaumgartner added the FeatureRequest Request for additional feature label Feb 23, 2020
@mibaumgartner mibaumgartner linked a pull request Feb 23, 2020 that will close this issue
19 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FeatureRequest Request for additional feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant