Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SteamScript does not continue after download finished #671

Closed
plata opened this issue Sep 4, 2018 · 1 comment · Fixed by #677
Closed

SteamScript does not continue after download finished #671

plata opened this issue Sep 4, 2018 · 1 comment · Fixed by #677
Labels

Comments

@plata
Copy link
Collaborator

plata commented Sep 4, 2018

The SteamScript checks the Steam manifest file to figure out if the download has finished. Therefore, it calls Wine#programFiles() which then runs "cmd ...".
This runs up to:

this._wineServer(subCategory, version, "-w");

And then it gets stuck in:
wineServerProcess.waitFor();

At this point, two wineserver are running (one with the Steam installation and one which has been started here). If the Steam wineserver shuts down, the script continues. So somehow the two wineservers are interfering.

I have no idea why this happens (what is different to before) or why we even have to wait until the wineserver shuts down (and not just until the process finished).

@qparis can you provide any insight on this?

Update: From my understanding, it's not a good idea to run multiple wine/wineserver in parallel in the same prefix.

Update 2: If we do not wait for the wineserver to end, e.g. the Steam installation continues after the installer and not after you shutdown Steam. As I don't know the reasoning behind waiting for wineserver, I cannot say if this is good or bad.

@plata plata added the bug label Sep 4, 2018
@plata
Copy link
Collaborator Author

plata commented Sep 9, 2018

There's a Stack Overflow topic about this exact question:

wineserver has a --wait flag which can be used to do exactly that.
However if you run multiple programs at once, it will wait for all of them to finish.

(https://stackoverflow.com/questions/7205856/waiting-for-wine-to-finish-running)

They suggest to wait only for the program and not for wineserver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant