Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Team1 not showing in matchpage if using imported team from Challonge w/o set country flag #148

Closed
JesusWithPants opened this issue Jun 27, 2022 · 1 comment · Fixed by #149

Comments

@JesusWithPants
Copy link
Contributor

JesusWithPants commented Jun 27, 2022

Continuing the bug from this Issue

After the bugfix under G5API - frontpage still does not show team1 status (presuming its due to the same bugged/flawed logic).

Match config:

{
    "matchid": "72",
    "match_title": "Map {MAPNUMBER} of {MAXMAPS}",
    "side_type": "standard",
    "veto_first": "team1",
    "skip_veto": true,
    "min_players_to_ready": 1,
    "players_per_team": 1,
    "team1": {
        "name": "Team Uno",
        "tag": "Team Uno",
        "flag": "",
        "matchtext": "Team Uno",
        "players": {
            "SteamID": "Player1"
        }
    },
    "team2": {
        "name": "Team Dos",
        "tag": "Team Dos",
        "flag": "",
        "matchtext": "Team Dos",
        "players": {
            "SteamID": "Player2"
        }
    },
    "cvars": {
        "get5_web_api_url": "https://get5.example.com/api",
        "get5_check_auths": "1"
    },
    "spectators": {
        "players": []
    },
    "maplist": [
        "de_inferno",
        "de_ancient",
        "de_mirage",
        "de_nuke",
        "de_overpass",
        "de_dust2",
        "de_vertigo"
    ],
    "min_spectators_to_ready": 0,
    "num_maps": 1
}

image

By a quick look - the teamID is there, just teamname is blanked out
image

Potential PR attached with a fix (could not test it out myself sadly).

@PhlexPlexico PhlexPlexico linked a pull request Jun 27, 2022 that will close this issue
@JesusWithPants
Copy link
Contributor Author

Confirmed fixed after PR Merge:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants