Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document fiscal sponsorship modeling #1506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bickelj
Copy link
Contributor

@bickelj bickelj commented Feb 19, 2025

Issue #1485 Support fiscal sponsor relationships between changemakers

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.10%. Comparing base (6a4f710) to head (7e92c33).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1506   +/-   ##
=======================================
  Coverage   87.10%   87.10%           
=======================================
  Files         243      243           
  Lines        3048     3048           
  Branches      420      420           
=======================================
  Hits         2655     2655           
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -25,6 +32,10 @@ returned value may come from a separate data source, such as a proposal to a
funder, a data platform provider (DataProvider in PDC), or the changemakers
themselves. As of this writing values come solely from proposals.

Rich field values ("gold" data) are returned in changemaker `fields`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does "Rich" mean in this context? How is it related to "gold" data? I understand "gold" in this context, as a term of art that we've defined elsewhere, but I don't understand what "rich" means (and the real-world tie-in between gold and richness is a possible source of confusion here).

Copy link
Contributor Author

@bickelj bickelj Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of having two separate sentences here is to describe the two separate lists (one named fields, one named fiscalSponsors) returned in the changemaker response body.

Both the parenthetical and the preceding paragraph provide the context for this note. Should I put it into the above paragraph? Rich is a better description than "gold" but I wanted to link the two here in case you've only ever heard of "gold" data. Should I eliminate either of those words? Ditch "rich" and keep "gold"?

Issue #1485 Support fiscal sponsor relationships between changemakers
Copy link
Member

@slifty slifty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From our conversation over jitsi I think we're all set with this now -- we have #1507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants