Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request: Draw grid lines over data #3446

Closed
davidgoli opened this issue Sep 21, 2017 · 1 comment · Fixed by #3451
Closed

Feature request: Draw grid lines over data #3446

davidgoli opened this issue Sep 21, 2017 · 1 comment · Fixed by #3451

Comments

@davidgoli
Copy link
Contributor

davidgoli commented Sep 21, 2017 •
edited
Loading

Our design requirement involves drawing grid lines on top of the data:
image

We have this working, but doing so required subclassing BarLineChartBase, copying nearly 100 lines of code from onDraw, then reordering operations slightly. This will probably be a maintenance nightmare going forward, so I am going to open a pull request so that other users will have this option in the future.
@davidgoli davidgoli changed the title Feature request: Draw graph lines over data Feature request: Draw grid lines over data Sep 21, 2017
@davidgoli davidgoli mentioned this issue Sep 23, 2017
Merged
@RobertZagorski
Copy link
Contributor

@davidgoli Do you think it would make sense to add such feature also to RadarChart? It has a variable mDrawWeb, which might be combined with what you added in your PR (AxisBase#mDrawGridLinesBehindData)

@siltrifork siltrifork mentioned this issue Dec 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to draw limit lines on top of data davidgoli/MPAndroidChart
2 participants
@davidgoli @RobertZagorski