Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when opening escape menu #101

Closed
ac-arcana opened this issue Mar 11, 2024 · 8 comments · Fixed by #103
Closed

Crash when opening escape menu #101

ac-arcana opened this issue Mar 11, 2024 · 8 comments · Fixed by #103
Assignees
Labels
bug Something isn't working

Comments

@ac-arcana
Copy link
Collaborator

On the latest build I am crashing whenever I press escape.
It is crashing on player_state_savetime on tab_menu_controller.gd:82

I deleted my userdata and this crash persists.

@Phazorknight
Copy link
Owner

Does this line appear in your output log?
CSM: Get existing player state: No player state found for slot [slot]

In any case, I'm pretty sure this is due to my careless implementation on how the menu reads any existing saved 😅 (deleting the data in this case unfortuantely won't help).
Should hopefully have a fix for you shortly...

@Phazorknight Phazorknight self-assigned this Mar 11, 2024
@Phazorknight Phazorknight added the bug Something isn't working label Mar 11, 2024
@ac-arcana
Copy link
Collaborator Author

image

@Phazorknight
Copy link
Owner

Can you give aca79f5 a try and see if that fixes it for you?

@ac-arcana
Copy link
Collaborator Author

Crashing in a different spot now...

image

image

@Phazorknight
Copy link
Owner

Okay, so this error is related to how the system time and date is read into a string and then parsed.
It just occurred to me that this string can probably differ in it's formatting depending on the OS settings.

Unfortuantely that's gonna be a bit tricky to troubleshoot for me, but if you could just add this line in the _ready() function of the cogito_scene_manager.gd and let me know what it prints out, it should help me narrow it down.

print("System datetime string: ", Time.get_datetime_string_from_system(false))

@ac-arcana
Copy link
Collaborator Author

image
as you requested :)

@Phazorknight
Copy link
Owner

Phazorknight commented Mar 11, 2024

@ac-arcana this looks like the time string format I worked with, so still odd that you got an error.
Anyway, I just merged @FailSpy 's PR with a possible fix into main.

Could you give it a go and see if it solves your issue?

(edit: accidentally closed this, reponed now)

@Phazorknight Phazorknight reopened this Mar 11, 2024
@ac-arcana
Copy link
Collaborator Author

It is fixed, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants