Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Trail for failed uploaded product and batch shows wrong command #1080

Closed
steinso2 opened this issue Dec 5, 2022 · 3 comments
Closed
Assignees
Labels
bug Something isn't working Enterprise Wallet Issues /Stories concerning upgrading the existing ePI platform - including ePI Enterprise wallet

Comments

@steinso2
Copy link

steinso2 commented Dec 5, 2022

Step:

  1. create json for a complete new product and keep one mandatory field empty
  2. upload json and get error message
    Result: the command shows that "editing" the product fails. But it should show: CREATION of a new product fails.
    Same in the Audit log:
    e.g. 2113111111140 Edited product - fail

Command and Audit log has to differentiate if a product was failed to be CREATED vs failed to be UPDATED/EDITED

@steinso2 steinso2 added bug Something isn't working Enterprise Wallet Issues /Stories concerning upgrading the existing ePI platform - including ePI Enterprise wallet labels Dec 5, 2022
@salboaie
Copy link
Member

salboaie commented Dec 5, 2022

@steinso2 when we generate that message we don't know if is creation or update. Changing now the whole flow for just this little detail looks wrong and risky. It is acceptable to just put at reason like "Message pre-validation Failed" ?

@steinso2
Copy link
Author

steinso2 commented Dec 5, 2022

@salboaie lets discuss in the audit trail meeting on Wednesday. The rules for the audit trail are quite strict and James needs to decide.

@salboaie
Copy link
Member

salboaie commented Dec 7, 2022

@adiganga2002 decision: put as reason : "Fail - See details"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Enterprise Wallet Issues /Stories concerning upgrading the existing ePI platform - including ePI Enterprise wallet
Projects
None yet
Development

No branches or pull requests

3 participants