Skip to content
This repository has been archived by the owner on Feb 18, 2020. It is now read-only.

Update Pokemon Database #96

Open
n2o opened this issue Feb 28, 2017 · 21 comments
Open

Update Pokemon Database #96

n2o opened this issue Feb 28, 2017 · 21 comments

Comments

@n2o
Copy link
Member

n2o commented Feb 28, 2017

New pokemon are coming and our database is not up-to-date. It would be nice if you help us keeping our database ready and filled with all pokemon needed. Currently it is stored in https://github.com/Phaetec/pogo-cruncher/blob/master/frontend/src/cruncher/data/pokemon.cljs

You can also provide them as JSON file or similar and I will convert it to our scheme. The last database was from an older IV analyzer, which is no longer supported.

@yroc78
Copy link

yroc78 commented Mar 1, 2017

I have caught most of the new ones is there any way I can help?

@n2o
Copy link
Member Author

n2o commented Mar 1, 2017

Yes, we need the data according to the database I linked above. Surely someone has created a list with the new pokemon and their attributes.

@yroc78
Copy link

yroc78 commented Mar 1, 2017

Do you have a way to get a hold of the mods at vegaspokemap.com ? Their tracker lists iv and attributes. I wish i knew how to code or crack api

@n2o
Copy link
Member Author

n2o commented Mar 1, 2017

That's not real "coding". We just have to add more pokemon to the database ;-)

@yroc78
Copy link

yroc78 commented Mar 1, 2017

@yroc78
Copy link

yroc78 commented Mar 2, 2017

it looks like a fairly complete list.
why doesn't the cruncher run? I've updated to the latest version. and restarted docker.
it blips "loading" then nothing happens.

@n2o
Copy link
Member Author

n2o commented Mar 2, 2017

We need the raw data of this website, which they don't seem to provide.

Can't confirm your issue. Tested it a minute ago with my Google (2FA) Account and our PTC testing account. Used the image with ID a3d352bda189 (see docker images), cruncher v0.3.3

@yroc78
Copy link

yroc78 commented Mar 2, 2017

tried to update through docker this is what I got

$ docker pull phaetec/pogo-cruncher
Using default tag: latest
latest: Pulling from phaetec/pogo-cruncher
Digest: sha256:995ce56aedff6c5f63e991e92e8a8d8ee74a0f79c3d669ad400e10c00ab958dc
Status: Image is up to date for phaetec/pogo-cruncher:latest

and my login attempt give this with the JS readout

Started Cruncher Version 0.3.2
cruncher.js:605  [  0.493s] [om.next] transacted '[(status/niantic {:status true})], #uuid "8f55c09b-cd76-41df-ae9e-7ff2d62b98a9"
http://localhost:8888/favicon.ico Failed to load resource: the server responded with a status of 404 (File not found)
cruncher.js:605  [  6.531s] [om.next] transacted '[(app/loading {:status true})], #uuid "9509a5eb-7e0d-444a-9d43-36ee0c247812"
http://localhost:5000/api/login Failed to load resource: the server responded with a status of 500 (INTERNAL SERVER ERROR)
cruncher.js:605  [ 31.367s] [om.next] transacted '[(app/loading {:status false})], #uuid "e240dff7-8ed8-4787-b107-5e787e86317d"
cruncher.js:605  [ 31.377s] [om.next] transacted '[(update/error {:message nil})], #uuid "2d981316-d374-4a89-93bd-ebe59ba22000"
cruncher.js:952 Seems like you're not catching 'em all any more... INTERNAL SERVER ERROR

@n2o
Copy link
Member Author

n2o commented Mar 2, 2017

Your image is correct, but your container is using the old image. I am confused how you start your containers. I'd suggest to remove all old containers and create a fresh one to avoid confusion. docker system prune can help you to delete all containers, all images and then you can start pulling the latest version of the cruncher.
As you can see in your js console output, you are using the old version 0.3.2, but the latest version is 0.3.3 where I fixed the login problem.

@yroc78
Copy link

yroc78 commented Mar 2, 2017

Ahh i didn't know about the "prune" I'll do that. Thank you for being so helpful

@yroc78
Copy link

yroc78 commented Mar 2, 2017

Had to clear my browser history then it loaded.
Thank you again for the help.

@n2o
Copy link
Member Author

n2o commented Mar 2, 2017

CTRL + SHIFT + R ;-) JavaScript files etc. are being cached by the browser.

@n2o n2o mentioned this issue Mar 7, 2017
@freefri
Copy link
Contributor

freefri commented Mar 7, 2017

cool, when can we be able to use #98 in production? Can we use it already in development? docker pull phaetec/pogo-cruncher:develop docker run -d -p 8888:8888 -p 5000:5000 phaetec/pogo-cruncher (I'm totally lost with how Docker deployments are working)

@n2o
Copy link
Member Author

n2o commented Mar 7, 2017

Just merged it. Images are building. This takes a few minutes.

@n2o
Copy link
Member Author

n2o commented Mar 7, 2017

Tests passed. Now hoping, that Docker Hub will do its job. Sometimes it is a bit annoying

@freefri
Copy link
Contributor

freefri commented Mar 7, 2017

We could make a script to download also pokemon pictures. Where did you take the originals (1st gen) from?
Next milestone should be update pokemon moves as well. Do we know any reliable source? (maybe this)

@n2o
Copy link
Member Author

n2o commented Mar 7, 2017

There was a repository somewhere on GitHub, which provided the original assets from the game...

@freefri
Copy link
Contributor

freefri commented Mar 7, 2017

Don't you remember the repo?
I think, people is not so much into pogo anymore, we could download this ones meanwhile the original ones from pogo are not easily available.
BTW, I've notice that pokemon without evolution display Evolves to: not-in-database I guess we will need to add :previous-evolutions [1 2] in the pokemon list in order to fix this. Can you confirm it from development?

@n2o
Copy link
Member Author

n2o commented Mar 7, 2017

I don't mind which pokemon images we are going to show. We can choose whatever we want. The assets repository is not maintained any more.
I can check this later.

Btw: GitHub Issues are not designed as a Chat replacement. We can use our Discord channel (see the badge in the README) for further discussions

@freefri freefri mentioned this issue Mar 8, 2017
4 tasks
@losEspinoza
Copy link

I was wondering if you were looking for any help. I've been looking for a project to jump back into code. I would love to help where I can.

@freefri
Copy link
Contributor

freefri commented Mar 24, 2017

This tool seems to be updated using new Pokemon images, stats and attacks. Maybe we could do some reverse engineering to get everything updated, fast and easy.
PD: let's join this on the Discord channel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants