Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting mod time #80

Open
slifty opened this issue Feb 21, 2023 · 0 comments
Open

Supporting mod time #80

slifty opened this issue Feb 21, 2023 · 0 comments

Comments

@slifty
Copy link
Contributor

slifty commented Feb 21, 2023

rclone, by default, uses size and mod time as ways of verifying that two files are the same (maybe checksum too but the mod time is the point of this issue).

Permanent doesn't have an explicit concept of "mod time" associated with a file.

This means that rclone's checks after file upload fail -- it "updates the mod time" (which does nothing) and then checks the mod time (which has not been updated / is simulated from some other file date), and so the modtime does not generally equal the expected value.

We have two options:

  1. Do not support default rclone; require users to set the --size-only and --sftp-set-modtime=false flags in order to sync with permanent

  2. Add support for file modtime to permanent's backend (and API and SDK). Modtime would become a nullable attribute of file. We would need an endpoint to allow setting of a modtime for a given file ID.

The second is the right solution; the first involves the least (i.e. no) development time.

@slifty slifty changed the title Mod time Supporting mod time Feb 21, 2023
This was referenced Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant